Skip to content

Switch to using new Go 1.19 CRL parser #12315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2023
Merged

Switch to using new Go 1.19 CRL parser #12315

merged 1 commit into from
Feb 15, 2023

Conversation

dbussink
Copy link
Contributor

x509.ParseCRL is deprecated, we should use x509.ParseRevocationList instead which is new in Go 1.19.

Related Issue(s)

Fixes #12314

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

@dbussink
Switch to using new Go 1.19 CRL parser
741fb38 
`x509.ParseCRL` is deprecated, we should use `x509.ParseRevocationList`
instead which is new in Go 1.19.

Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink added Type: Internal Cleanup Component: General Changes throughout the code base labels Feb 11, 2023
@dbussink dbussink requested a review from deepthi as a code owner February 11, 2023 13:34
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 11, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 11, 2023 •
edited by deepthi
Loading

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

dbussink
dbussink commented Feb 11, 2023
View reviewed changes
go/vt/tlstest/tlstest.go
block, _ := pem.Decode(data)
if block == nil || block.Type != "X509 CRL" {
log.Fatal("failed to parse CRL PEM")
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PEM decoding is not done implicitly with x509.ParseRevocationList so this needs to be done here explicitly in the tests.

go/vt/vttls/crl.go
@@ -83,7 +82,7 @@ func loadCRLSet(crl string) ([]*pkix.CertificateList, error) {
continue
}

parsedCRL, err := x509.ParseCRL(block.Bytes)
parsedCRL, err := x509.ParseRevocationList(block.Bytes)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PEM decoding here is already done explicitly so there's no user facing changes in the usage (still only PEM formatted CRLs are supported).

@dbussink
Copy link
Contributor Author

FYI @hkdsun as original contributor of the CRL support. To be clear, at the time this was the right API since Go 1.19 didn't exist yet, but we should still switch now to the newer API.

@dbussink dbussink removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Feb 11, 2023
@deepthi deepthi merged commit d598c7f into vitessio:main Feb 15, 2023
@dbussink dbussink deleted the fix-deprecated-crl-parsing branch February 24, 2023 13:39
frouioui pushed a commit to planetscale/vitess that referenced this pull request Feb 24, 2023
@dbussink @frouioui
Switch to using new Go 1.19 CRL parser (vitessio#12315)
add5eb5 
`x509.ParseCRL` is deprecated, we should use `x509.ParseRevocationList`
instead which is new in Go 1.19.

Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
@frouioui frouioui mentioned this pull request Feb 24, 2023
Merged
3 tasks
frouioui added a commit that referenced this pull request Feb 27, 2023
@frouioui @dbussink
Upgrade release-16.0 to go1.20.1 (#12398)
aa377fb 
* Upgrade release-16.0 to go1.19.6

Signed-off-by: Florent Poinsard <[email protected]>

* upgrade to 1.20.1

Signed-off-by: Florent Poinsard <[email protected]>

* bump the golangci-lint version

Signed-off-by: Florent Poinsard <[email protected]>

* Apply linter suggestions

Signed-off-by: Florent Poinsard <[email protected]>

* Apply linter suggestions

Signed-off-by: Florent Poinsard <[email protected]>

* fix TestTLSClientVerifyIdentity

Signed-off-by: Florent Poinsard <[email protected]>

* Switch to using new Go 1.19 CRL parser (#12315)

`x509.ParseCRL` is deprecated, we should use `x509.ParseRevocationList`
instead which is new in Go 1.19.

Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>

* Skip TestFuzz for now

Signed-off-by: Florent Poinsard <[email protected]>

---------

Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
Co-authored-by: Dirkjan Bussink <[email protected]>
timvaillancourt pushed a commit to slackhq/vitess that referenced this pull request Sep 12, 2023
@frouioui @dbussink @timvaillancourt
Upgrade release-16.0 to go1.20.1 (vitessio#12398)
e364dc9 
* Upgrade release-16.0 to go1.19.6

Signed-off-by: Florent Poinsard <[email protected]>

* upgrade to 1.20.1

Signed-off-by: Florent Poinsard <[email protected]>

* bump the golangci-lint version

Signed-off-by: Florent Poinsard <[email protected]>

* Apply linter suggestions

Signed-off-by: Florent Poinsard <[email protected]>

* Apply linter suggestions

Signed-off-by: Florent Poinsard <[email protected]>

* fix TestTLSClientVerifyIdentity

Signed-off-by: Florent Poinsard <[email protected]>

* Switch to using new Go 1.19 CRL parser (vitessio#12315)

`x509.ParseCRL` is deprecated, we should use `x509.ParseRevocationList`
instead which is new in Go 1.19.

Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>

* Skip TestFuzz for now

Signed-off-by: Florent Poinsard <[email protected]>

---------

Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
Co-authored-by: Dirkjan Bussink <[email protected]>
timvaillancourt pushed a commit to slackhq/vitess that referenced this pull request Mar 15, 2024
@frouioui @dbussink @timvaillancourt
Upgrade release-16.0 to go1.20.1 (vitessio#12398)
b13b348 
* Upgrade release-16.0 to go1.19.6

Signed-off-by: Florent Poinsard <[email protected]>

* upgrade to 1.20.1

Signed-off-by: Florent Poinsard <[email protected]>

* bump the golangci-lint version

Signed-off-by: Florent Poinsard <[email protected]>

* Apply linter suggestions

Signed-off-by: Florent Poinsard <[email protected]>

* Apply linter suggestions

Signed-off-by: Florent Poinsard <[email protected]>

* fix TestTLSClientVerifyIdentity

Signed-off-by: Florent Poinsard <[email protected]>

* Switch to using new Go 1.19 CRL parser (vitessio#12315)

`x509.ParseCRL` is deprecated, we should use `x509.ParseRevocationList`
instead which is new in Go 1.19.

Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>

* Skip TestFuzz for now

Signed-off-by: Florent Poinsard <[email protected]>

---------

Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
Co-authored-by: Dirkjan Bussink <[email protected]>
timvaillancourt added a commit to slackhq/vitess that referenced this pull request Mar 15, 2024
@timvaillancourt @dbussink
@systay @frouioui
slack-vitess-r15.0.5: use go1.20.14 (#255)
3548975 
* go1.20.14

Signed-off-by: Tim Vaillancourt <[email protected]>

* more go-version: updates

Signed-off-by: Tim Vaillancourt <[email protected]>

* make proto w/go1.20

Signed-off-by: Tim Vaillancourt <[email protected]>

* Fix the golangci-lint config (vitessio#11812)

There's a bunch of deprecated linters that don't work anymore, so let's
remove them:

```
WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [linters context] structcheck is disabled because of generics. You can track the evolution of the generics support by following the golangci/golangci-lint#2649.
```

Signed-off-by: Dirkjan Bussink <[email protected]>

Signed-off-by: Dirkjan Bussink <[email protected]>

* update golangci-lint to 1.50.1 (vitessio#11873)

Signed-off-by: Andres Taylor <[email protected]>

Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>

* Add timeout to golangci-lint and bump its version (vitessio#12852) (vitessio#12853)

Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Tim Vaillancourt <[email protected]>

* Upgrade `release-16.0` to `go1.20.1` (vitessio#12398)

* Upgrade release-16.0 to go1.19.6

Signed-off-by: Florent Poinsard <[email protected]>

* upgrade to 1.20.1

Signed-off-by: Florent Poinsard <[email protected]>

* bump the golangci-lint version

Signed-off-by: Florent Poinsard <[email protected]>

* Apply linter suggestions

Signed-off-by: Florent Poinsard <[email protected]>

* Apply linter suggestions

Signed-off-by: Florent Poinsard <[email protected]>

* fix TestTLSClientVerifyIdentity

Signed-off-by: Florent Poinsard <[email protected]>

* Switch to using new Go 1.19 CRL parser (vitessio#12315)

`x509.ParseCRL` is deprecated, we should use `x509.ParseRevocationList`
instead which is new in Go 1.19.

Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>

* Skip TestFuzz for now

Signed-off-by: Florent Poinsard <[email protected]>

---------

Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
Co-authored-by: Dirkjan Bussink <[email protected]>

* Remove recent golangci-lint version bump (vitessio#12909)

Signed-off-by: Florent Poinsard <[email protected]>

* Fix conflict resolution

Signed-off-by: Tim Vaillancourt <[email protected]>

* make ensure_bootstrap_version

Signed-off-by: Tim Vaillancourt <[email protected]>

* hardcode previous release

Signed-off-by: Tim Vaillancourt <[email protected]>

* Add comment for hardcoded previous release

Signed-off-by: Tim Vaillancourt <[email protected]>

---------

Signed-off-by: Tim Vaillancourt <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: Dirkjan Bussink <[email protected]>
Co-authored-by: Andres Taylor <[email protected]>
Co-authored-by: Florent Poinsard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@frouioui frouioui frouioui approved these changes

Assignees
No one assigned
Labels
Component: General Changes throughout the code base Type: Internal Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated usage of x509.ParseCRL
3 participants
@dbussink @deepthi @frouioui