-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
[Chore] remove unused jinaai_serving_reranking #18878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Abirdcfly <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Could you elaborate? Which PR made this unused? |
maybe #12846 renamed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, let's rename it to serving_scores
instead of openai_serving_scores
to be less misleading
It seems my screenshot may have caused confusion. The point I intended to convey was that there's a single definition for As for the naming of |
That's because the other APIs follow OpenAI API. However, this one does not, so I think it's better to have a different name for it to avoid confusion. |
No description provided.