Improve type hints #51
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was not sure what the minimal Python version for type hints is supported, so I tried to be the most compatible. However, I believe it still needs Python 3.5 to be able to import
Type
fromtyping
.Things that could be simplified/improved:
Protocol
(Python 3.8).read
and.write
(Python 3.8)type
instead ofType
(Python 3.9)Callable
fromcollections.abc
(Python 3.10)Things not treated in this PR:
bytes | bytearray
tobytes
(mypy doc): it does not hurt to keep it this way**options
params: it does not bring a lot to type them properly, and it adds maintainability burden (e.g. you would need to modify the type hints each time you add a new param)