-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Sync #c9e1ad4 #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Sync #c9e1ad4 #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Missing 'the' in attrs.md * Update src/guide/components/attrs.md Co-authored-by: Natalia Tepluhina <[email protected]>
* Minor lexical improvements to composables.md * Update src/guide/reusability/composables.md Co-authored-by: skirtle <[email protected]> Co-authored-by: skirtle <[email protected]>
* fix: fix typo * fix: fix minor grammar error
This proposal is to remove the usage of the `indexOf` method when testing for the presence of a given character in a string. While `indexOf` is compatible with IE, `includes` is friendlier to newer JavaScript developers and it improves code readability.
Note: these changes are already reflected in the review commits for the Chinese translation and do not need to be translated.
In multiline example was used message ref for v-model, so example above "message" was changing if we writed something in multiline section.
No need to translate
This reverts commit 1e78e50.
* fix(PreferenceSwitch): switch-link style overflow Signed-off-by: Sepush <[email protected]> * Update .vitepress/theme/components/PreferenceSwitch.vue Co-authored-by: skirtle <[email protected]> Co-authored-by: skirtle <[email protected]>
* Fix grammar * Update src/tutorial/src/step-9/description.md Co-authored-by: Fuqiao Xue <[email protected]> Co-authored-by: Fuqiao Xue <[email protected]>
close #1894
# Conflicts: # .vitepress/config.ts # .vitepress/theme/index.ts # src/about/faq.md # src/about/releases.md # src/about/team/TeamPage.vue # src/api/built-in-directives.md # src/api/component-instance.md # src/api/composition-api-lifecycle.md # src/api/options-lifecycle.md # src/api/options-misc.md # src/api/options-state.md # src/api/reactivity-core.md # src/guide/best-practices/performance.md # src/guide/best-practices/security.md # src/guide/built-ins/keep-alive.md # src/guide/built-ins/transition.md # src/guide/components/async.md # src/guide/components/attrs.md # src/guide/components/events.md # src/guide/components/props.md # src/guide/components/slots.md # src/guide/extras/composition-api-faq.md # src/guide/extras/reactivity-in-depth.md # src/guide/extras/reactivity-transform.md # src/guide/extras/render-function.md # src/guide/reusability/composables.md # src/guide/reusability/plugins.md # src/guide/scaling-up/routing.md # src/guide/scaling-up/sfc.md # src/guide/scaling-up/ssr.md # src/guide/scaling-up/testing.md # src/guide/typescript/overview.md # src/partners/components/PartnerHero.vue # src/translations/index.md # src/tutorial/src/step-2/App/composition.js # src/tutorial/src/step-2/App/options.js # src/tutorial/src/step-7/description.md # src/tutorial/src/step-9/description.md
✅ Deploy Preview for vue-docs-zh-cn ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Jinjiang
reviewed
Aug 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
其他:
- 少了
src/public/images/sponsors/.gitkeep
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: Jinjiang <[email protected]>
Co-authored-by: Jinjiang <[email protected]>
这个文件在英文仓库是被 delete 的哦 @Jinjiang |
Jinjiang
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
vuejs/docs@be5fe37...c9e1ad4
大部分更新已经在 Evan 的 #487 中覆盖了。