Skip to content

fix: onServerPrefetch getting stuck prevention #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

fix: onServerPrefetch getting stuck prevention #1435

wants to merge 4 commits into from

Conversation

fabis94
Copy link
Contributor

@fabis94 fabis94 commented Dec 9, 2022 •
edited
Loading

closes #1429

@fabis94
Copy link
Contributor Author

fabis94 commented Dec 9, 2022

I needed the empty yarn.lock to be able to link vue composable into my local project, I'll remove it once this PR is ready to be merged

This was referenced Dec 9, 2022
Closed
Closed
Akryum added a commit that referenced this pull request May 16, 2023
@Akryum
fix(ssr): handle result/error set before serverPrefetch call, fix #1429
d5f6275 
Original PR #1435 by @fabis94
@Akryum
Copy link
Member

Akryum commented May 16, 2023

Thanks!
I didn't have the permissions to push to this PR so I made the changes here: d5f6275

@Akryum Akryum closed this May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onServerPrefetch() should check if result is already filled
2 participants
@fabis94 @Akryum