test(shared): improve test coverage #8456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
CodSpeed Performance ReportMerging #8456 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
I'm a bit confused by the changes in your last commit. The second normalizeStyle section has been entirely removed. While some of those tests were maybe duplicates of the tests in the other normalizeStyle section, most of them did seem to be testing different things. When I mentioned the duplicate section in my earlier review I had intended for you to combine the tests into a single section, not remove them all.
I think those tests should be brought back.
I've included some other minor suggestions below.
❌ Deploy Preview for vue-next-template-explorer failed.
|
❌ Deploy Preview for vue-sfc-playground failed.
|
|
commit: @vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
|
dqrcodebase
added a commit
to dqrcodebase/core
that referenced
this pull request
Nov 6, 2024
* core/main: (94 commits) chore(deps): update dependency @types/node to v22 (vuejs#12320) chore(deps): update lint (vuejs#12319) chore(deps): update all non-major dependencies (vuejs#12316) chore(deps): update build (vuejs#12317) chore(deps): update pnpm to v9.12.3 (vuejs#12278) chore(deps): update dependency typescript-eslint to ^8.11.0 (vuejs#12276) chore(deps): update dependency npm-run-all2 to v7 (vuejs#12277) chore(deps): update all non-major dependencies (vuejs#12275) chore(deps): update build (vuejs#12274) chore(deps): update all non-major dependencies (vuejs#12222) chore(deps): update lint (vuejs#12226) chore(deps): update build (vuejs#12223) docs: update package name to `@vue/compiler-core` (vuejs#12192)[ci skip] chore(deps): update dependency typescript-eslint to ^8.8.1 (vuejs#12167) chore(deps): update dependency magic-string to ^0.30.12 (vuejs#12166) fix(test): update snapshot (vuejs#12169) chore: improve `renderComponentRoot` warn message (vuejs#10914) test(shared): improve test coverage (vuejs#8456) test(defineProps): add intersection type test (vuejs#8684) chore(deps): update dependency @swc/core to ^1.7.35 (vuejs#12165) ...
abdullah-wn
pushed a commit
to Lazy-work/vue
that referenced
this pull request
Jan 4, 2025
Co-authored-by: edison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.