Fix: allow v-on without attribute values if it has verb modifiers (fixes #49)
#50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HerringtonDarkholme
approved these changes
Jun 25, 2017
michalsnik
approved these changes
Jun 26, 2017
| @@ -58,7 +62,7 @@ tester.run('no-invalid-v-on', rule, { | |||
| { | |||
| filename: 'test.vue', | |||
| code: '<template><div v-on:click></div></template>', | |||
| errors: ["'v-on' directives require that attribute value."] | |||
| errors: ["'v-on' directives require that attribute value or verb modifiers."] | |||
There was a problem hiding this comment.
Even though @ is a simple alias I think it would be good idea to add more valid test examples with v-on, like e.g.:
<template><div v-on:click.prevent></div></template>
<template><div v-on:click.native.stop></div></template>
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49.
This PR fixes false positive of
no-invalid-v-onrule.If a
v-ondirective has verb modifiers (.stopor.prevent), now that rule allow the directive even if it does not have attribute values.