Fix #553, add possibility to define network protocol in config #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adm-bome
requested changes
Jul 11, 2023
README.md
Outdated
| 'options' => [ | ||
| // ... | ||
|
|
||
| 'network_protocol' => 'network wanted', |
There was a problem hiding this comment.
I rather see this one level up. And accessed via
Arr::get($config, 'network_protocol')Because network connection config is defined next to lazy and secure config parameters.
The options are more intended for config in the worker Class.
Now this is a bit misleading, as whe have to handle legacy config structure prior to v13.3.0
There was a problem hiding this comment.
And maybe document the available protocols
There was a problem hiding this comment.
Thanks for your review, I updated the PR with your suggestions
adm-bome
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #553