Skip to content

Fix Speech to Text bugs #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 14, 2018
Merged

Fix Speech to Text bugs #1006

merged 4 commits into from
Nov 14, 2018

Conversation

lpatino10
Copy link
Contributor

Fixes #1004 and fixes #1005.

A ping interval was added in the recognizeUsingWebSocket() method to ensure that no timeouts occur. Apparently, this was causing issue #1004, according to this issue in the OkHttp repo.

@codecov-io
Copy link

codecov-io commented Nov 14, 2018

Codecov Report

Merging #1006 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1006      +/-   ##
============================================
+ Coverage     64.58%   64.61%   +0.02%     
  Complexity     3099     3099              
============================================
  Files           679      679              
  Lines         16523    16525       +2     
  Branches        918      918              
============================================
+ Hits          10672    10677       +5     
+ Misses         5355     5353       -2     
+ Partials        496      495       -1
Impacted Files Coverage Δ Complexity Δ
...loud/speech_to_text/v1/model/RecognizeOptions.java 72.41% <100%> (+0.23%) 19 <0> (ø) ⬇️
...eveloper_cloud/speech_to_text/v1/SpeechToText.java 89.79% <100%> (+0.02%) 85 <0> (ø) ⬇️
.../watson/developer_cloud/service/WatsonService.java 58.85% <0%> (+1.56%) 41% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebaab70...10cc474. Read the comment docs.

Copy link
Contributor

@mediumTaj mediumTaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good! Will behavior be affected if the user sets inactivity_timeout?

@lpatino10
Copy link
Contributor Author

Nope @mediumTaj, that should override the pings to close the connection. Good question though!

@lpatino10 lpatino10 merged commit 9014348 into master Nov 14, 2018
@lpatino10 lpatino10 deleted the stt-patch branch November 14, 2018 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[speech-to-text] Interim results set to true but seeing final results [speech-to-text] EOFException during audio file processing
3 participants