Skip to content

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=265734 #52793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mattwoodrow
Copy link
Contributor

@wpt-pr-bot
Copy link
Collaborator

This patch has been exported from WebKit; it will be approved automatically once the downstream patch is r+.

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the WebKit project.

@nt1m nt1m enabled auto-merge (rebase) May 30, 2025 14:25
@nt1m nt1m disabled auto-merge May 30, 2025 14:25
@nt1m nt1m closed this May 30, 2025
@nt1m nt1m reopened this May 30, 2025
@gsnedders
Copy link
Member

@nt1m @mattwoodrow do we think this can land as is, or can something be done to mitigate the Firefox flakiness? (cc @emilio)

@emilio
Copy link
Contributor

emilio commented Jun 3, 2025

It seems the test is mostly fuzzy, not broken? Maybe using animation-play-state: paused rather than animation-duration: 500ms helps mitigate it

@emilio
Copy link
Contributor

emilio commented Jun 3, 2025

(On the other hand it's visibility: hidden, so shouldn't matter I think? I can look at it more tomorrow, feel free to land as-is)

@mattwoodrow
Copy link
Contributor Author

Is there any way to view to failing images?

The idea of the test is that the 'target' view transition name animation is running, but the new/old images should be identical, so shouldn't be racy.

The 'root' animation is hidden, so anything not in target (including target itself if the spanning got detected as being fragmented) isn't in the capture at all.

The failing fuzz values seem fairly large, is it possible that one of the new/old captures is missing, so it's racily capturing a fade-in/out?

@emilio
Copy link
Contributor

emilio commented Jun 4, 2025

@mattwoodrow so running the test on firefox nighly, I see that what happens is that we capture the old state just fine because it's not fragmented yet, and then fade it out, and skip the new one because it's fragmented, so there's a fade-out animation of the old content that is what's causing the flakyness.

I think (from memory, haven't dug, lmk if I'm wrong) that's right per spec? If so I think you need to hide the ::view-transition-old(target) pseudo to make the test not have that animation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants