-
Notifications
You must be signed in to change notification settings - Fork 3.4k
WebKit export of https://bugs.webkit.org/show_bug.cgi?id=265734 #52793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
WebKit export of https://bugs.webkit.org/show_bug.cgi?id=265734 #52793
Conversation
This patch has been exported from WebKit; it will be approved automatically once the downstream patch is r+. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review process for this patch is being conducted in the WebKit project.
@nt1m @mattwoodrow do we think this can land as is, or can something be done to mitigate the Firefox flakiness? (cc @emilio) |
It seems the test is mostly fuzzy, not broken? Maybe using |
(On the other hand it's |
Is there any way to view to failing images? The idea of the test is that the 'target' view transition name animation is running, but the new/old images should be identical, so shouldn't be racy. The 'root' animation is hidden, so anything not in target (including target itself if the spanning got detected as being fragmented) isn't in the capture at all. The failing fuzz values seem fairly large, is it possible that one of the new/old captures is missing, so it's racily capturing a fade-in/out? |
@mattwoodrow so running the test on firefox nighly, I see that what happens is that we capture the old state just fine because it's not fragmented yet, and then fade it out, and skip the new one because it's fragmented, so there's a fade-out animation of the old content that is what's causing the flakyness. I think (from memory, haven't dug, lmk if I'm wrong) that's right per spec? If so I think you need to hide the |
WebKit export from bug: [view-transitions] Exclude fragmented boxes from capture