Keep clip mask for backdrop filter in clip's coordinate space #52875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, as the synthetic effect node for the filter could be applied in a different transform space, the clip mask was transformed to be in the same space. This is problematic if there is a transform animation between the backdrop effect and the clip, as the clip bounds are now in a stale coordinate space (still of the old transform space). Instead, we conditionally track the clip's ID in the mask filter info. This ID can be used to look up the correct transform space when updating the transform to map the the render surface. Bug: 401816608, 401543213 Change-Id: I9201773d9a37b76241f664938d5fb07d376164c6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, as the synthetic effect node for the filter could be
applied in a different transform space, the clip mask was transformed
to be in the same space. This is problematic if there is a transform
animation between the backdrop effect and the clip, as the clip
bounds are now in a stale coordinate space (still of the old
transform space). Instead, we conditionally track the clip's ID in
the mask filter info. This ID can be used to look up the correct
transform space when updating the transform to map the the render
surface.
Bug: 401816608, 401543213
Change-Id: I9201773d9a37b76241f664938d5fb07d376164c6
Reviewed-on: https://chromium-review.googlesource.com/6579330
WPT-Export-Revision: d422580c1ff0526c6297fcd2bf8ea03a0d7a5b53