-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add test for fragment handling in data URIs #8109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for fragment handling in data URIs #8109
Conversation
This is my attempt at a WPT capturing the correct handling of '#' characters in data URIs. See http://crbug.com/123004 for the Chrome bug, and whatwg/fetch#579 where @annevk is working on making the spec clearer regarding what is correct here. I'm very open to suggestions for how to do this test 'better'. I wasn't able to find a way in js to get back what would be the "data" of a parsed data URI, so ended up just doing a reftest using <object>. |
@RByers as an FYI. |
Build PASSEDStarted: 2017-11-08 15:52:59 View more information about this build on: |
This looks pretty good. You can also generate HTML with a data URL in an As far as standards go. I think most folks agree that this is defined even with the original RFCs, it's just not super clear. But indeed that Fetch PR coupled with https://url.spec.whatwg.org/ should make it crystal clear. |
Build PENDINGStarted: None View more information about this build on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on the assumption that this passes in Firefox. If it doesn't I need to take a closer look. Let me know if you need help landing this. I recommend squash & merge, combined with modifying the commit title and message.
Looks like it passes in Firefox: https://pulls.web-platform-tests.org/job/20527.4 However CI failed due to linting errors: https://travis-ci.org/w3c/web-platform-tests/jobs/301503683#L549 |
Yes, sorry, I pushed a half-finished version by mistake. Will fix the linter errors, re-upload, and submit :). Thanks for the review! |
No description provided.