-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[Doc] Fix doc issue of sendTransaction #7245
[Doc] Fix doc issue of sendTransaction #7245
Conversation
@luu-alex Hi, it seems that this PR does not cause the CI error. Could you please review the RP and help it? |
@mconnelly8 @luu-alex @avkos Could you help review this PR? 😄 |
* const transactionHash = await web3.eth.sendTransaction(transaction); | ||
* console.log(transactionHash); | ||
* > 0xdf7756865c2056ce34c4eabe4eff42ad251a9f920a1c620c00b4ea0988731d3f | ||
* const transactionReceipt = await web3.eth.sendTransaction(transaction); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For minor changes pls create issue so some one from web3 team can update it if required. Its for avoiding airdrop farming.
@jdevcs I solved an issue that had existed for 2 months. I believe this issue was created by the maintainer team. I didn't see anyone expressing willingness to resolve it. Small issues are the best choice for people who are just getting familiar with the project. Larger changes are not suitable for anyone who has just become familiar with the project. This is an open-source project. If you don't want this project to be associated with airdrops, I suggest you inform all project parties not to give airdrops to contributors of web3.js. If you don't want open-source personnel to contribute code, you can directly set permissions. Closing a PR for such reasons is unreasonable. |
We appreciate your perspective and encourage you to submit code contributions on Github. You can also check out and help solve some bugs or add code contributions from the issues : https://github.com/web3/web3.js/issues?q=is%3Aopen+is%3Aissue+label%3A%22Good+First+Issue%22 or from list of other issue https://github.com/web3/web3.js/issues. Your engagement is valuable to our project. |
Description
Fix #7185
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.