Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

[Doc] Fix doc issue of sendTransaction #7245

Conversation

blackmoshui
Copy link
Contributor

@blackmoshui blackmoshui commented Sep 9, 2024

Description

Fix #7185

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@blackmoshui
Copy link
Contributor Author

@luu-alex Hi, it seems that this PR does not cause the CI error. Could you please review the RP and help it?

@blackmoshui
Copy link
Contributor Author

@mconnelly8 @luu-alex @avkos Could you help review this PR? 😄

* const transactionHash = await web3.eth.sendTransaction(transaction);
* console.log(transactionHash);
* > 0xdf7756865c2056ce34c4eabe4eff42ad251a9f920a1c620c00b4ea0988731d3f
* const transactionReceipt = await web3.eth.sendTransaction(transaction);
Copy link
Contributor

@jdevcs jdevcs Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For minor changes pls create issue so some one from web3 team can update it if required. Its for avoiding airdrop farming.

@jdevcs jdevcs closed this Sep 26, 2024
@blackmoshui
Copy link
Contributor Author

@jdevcs I solved an issue that had existed for 2 months. I believe this issue was created by the maintainer team. I didn't see anyone expressing willingness to resolve it.

Small issues are the best choice for people who are just getting familiar with the project. Larger changes are not suitable for anyone who has just become familiar with the project.

This is an open-source project. If you don't want this project to be associated with airdrops, I suggest you inform all project parties not to give airdrops to contributors of web3.js. If you don't want open-source personnel to contribute code, you can directly set permissions.

Closing a PR for such reasons is unreasonable.

@jdevcs
Copy link
Contributor

jdevcs commented Sep 26, 2024

We appreciate your perspective and encourage you to submit code contributions on Github. You can also check out and help solve some bugs or add code contributions from the issues : https://github.com/web3/web3.js/issues?q=is%3Aopen+is%3Aissue+label%3A%22Good+First+Issue%22 or from list of other issue https://github.com/web3/web3.js/issues. Your engagement is valuable to our project.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs - sendtransaction has wrong return in docs
3 participants