insertInto and ShadowDom

[cdbkr]

Regarding #135 , "insertInto" seems to me incomplete or obsolete (or missing extra features) at the moment when combining it with ShadowDom.
In the ReadME there is the following example:

{
  loader: 'style-loader'
  options: {
    insertInto: '#host::shadow>#root'
  }
}

My concern is that the pseudo selector "::shadow" is going (probably it is) to be deprecated along with "/deep/".

Are you aware of any other way to replicate the example above using css selectors?

Maybe, an improved/extended way would be a direct access to the element's shadowRoot - declaring or inspecting the element's 'nature' - , of course supporting also simple elements such as the one in the tests https://github.com/webpack-contrib/style-loader/blob/master/test/basicTest.js#L98 (a simple div with "target" as class).

[LukasBombach]

I could use this too. It seems ::shadow is deprecated now. However, this could be shimmed. We could check if a ::shadow selector is present and just do

querySelector('#selectorUnitlShadow').shadowRoot

or

querySelector('#selectorUnitlShadow').shadowRoot.querySelector('.possibleDeeperQueries')

respectively.

Would the maintainers care for such a PR?

[LukasBombach]

This works: master...LukasBombach:allow-insertInto-shadow-dom

I'm gonna test this a little bit tomorrow, write unit tests and might open a PR if you want to.

[morewry]

I just copied this from the README #host::shadow>#root and got Uncaught Error: Couldn't find a style target. This probably means that the value for the 'insertInto' parameter is invalid.

I take it this means it's a CSS selector and you have to write a really specific selector for a shadow root. However, this selector doesn't function in recent versions of Chrome (no longer shows a deprecation warning, even, which may mean it's been removed).

A very specific selector...since IDs are unique and used by all the examples, there's an implication that you can only put the styles inside one shadow root? Very little about this appears tenable to me for a web component. Since you don't control what IDs or classes a component consumer puts on the hosting element, this would require every consumer to do a webpack config that supports how you as the author intend your component to be built, because you can't (so far as I can tell) effectively distribute your component with the styles already built in. And how are you supposed to place the styles for a web component composed from other web components in the right places? There are multiple shadow roots encapsulated inside other shadow roots.

[LukasBombach]

@morewry Regarding the CSS selector for finding your web component. When you setup your project you are in control of the HTML, so you can write any specific CSS selector that fits your HTML, you don't have to account for users using your web component differently. In the end you compile everything and ship your component with the styles included independent of what selector you used during development. I hope I understood your remark right.

Regarding nested custom elements. With the code I provided in the post before yours, you could do

{
    insertInto: 'my-component::shadow > #whatever > my-nested-component::shadow'
}

[savelichalex]

Looks like ::shadow not working now. What you guys think if I create PR that allow to use function in insertInto options? Smth like this

{
  insertInto: () => document.querySelector('.foo')
}

Instead of this: https://github.com/webpack-contrib/style-loader/blob/master/lib/addStyles.js#L46-L48

[herodrigues]

@savelichalex ::shadow is deprecated. It's from Shadow DOM v0 spec.

A solution would be to check if the target element has a shadow root.

[savelichalex]

@herodrigues Yeah, you absolutely right 😄 And this is why I want to select target with custom function. Maybe I misspelling a little, check out this

{
  insertInto: () => document.querySelector('.foo').shadowRoot
}

And now in this place loader will be append new styles

[cdbkr]

@savelichalex that makes sense. it might even be memoized for performance reasons.

[savelichalex]

Add PR for this #279

[austinwalter]

Is there a way to use insertInto if the HTML element it would insert into isn't created until the application is launched? I'm using this with a chrome extension content script and so I don't have access to the document immediately. Because of this the style-loader is trying to insert the styles before I actually get to create the element!

[michael-ciniawsky]

Closed by #279, released in v0.20.0 🎉