Allow to specify element into which to inject Style. #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Romain Dardour <[email protected]>
|
HI @unity How do you pass the corresponding element in the webpack config? Thanks |
|
You pass it at runtime : import style from './style.css'
style.use(document.getElementById('myId')); |
|
is there any chance this will be merged? Would love to use this for iframes |
|
Currently this PR has conflicts. Rebasing would be a good start. Would like to see this merged too. |
michael-ciniawsky
requested changes
Mar 6, 2017
| @@ -95,11 +95,11 @@ function listToStyles(list) { | |||
| return styles; | |||
| } | |||
|
|
|||
| function createStyleElement() { | |||
| function createStyleElement(element) { | |||
| var styleElement = document.createElement("style"); | |||
There was a problem hiding this comment.
parentElement => element
There was a problem hiding this comment.
and all following references to them please :)
|
Could you rebase and add tests where possible? Thanks. |
ekulabuhov
reviewed
Mar 6, 2017
| getHeadElement = memoize(function () { | ||
| return document.head || document.getElementsByTagName("head")[0]; | ||
| }), | ||
| getElement = function (element) { |
There was a problem hiding this comment.
I don't see a reason to remove memoization.
Merged
|
Superseded by #135 Thx 😛 |
import style from './style.css'
style.use(parent.document.getElementById('myId'));IMO, this way is more useful than set config in style-loader. Consider to add this feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use this to allow injecting a Style tag into a different place than HEAD.
We use React+Webpack a lot to bundle reusable applications embedded in a 3rd party page.
Here are two examples of how we benefit from this PR: