Skip to content

test(options): set jest.setTimeout #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2019
Merged

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Jun 8, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

modify only

Motivation / Use-Case

We changed the time from 30000 to 60000, but options.test.js has many execution times.
So, I specified 20000 as jest.setTime to options.tests.js.
in next branch, this file is refactored and the execution is quite fast.
https://github.com/webpack/webpack-dev-server/blob/feature/refactor-tests/test/options.test.js

Breaking Changes

no

Additional Info

@hiroppy hiroppy requested a review from alexander-akait as a code owner June 8, 2019 08:16
@codecov
Copy link

codecov bot commented Jun 8, 2019

Codecov Report

Merging #1999 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1999   +/-   ##
=======================================
  Coverage   92.52%   92.52%           
=======================================
  Files          28       28           
  Lines        1083     1083           
  Branches      324      324           
=======================================
  Hits         1002     1002           
  Misses         77       77           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fe3fbd...80072b4. Read the comment docs.

@hiroppy hiroppy merged commit ce81c69 into master Jun 8, 2019
@hiroppy hiroppy deleted the feature/fix-options.test branch June 8, 2019 16:26
hiroppy added a commit that referenced this pull request Jun 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants