Skip to content

refactor: do not use webpack directly #3414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

alexander-akait
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

no need, existing

Motivation / Use-Case

Do not use webpack directly, because on the top can exists webpack v4 and it will break logic

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #3414 (15b1286) into master (1b0f514) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3414      +/-   ##
==========================================
+ Coverage   95.10%   95.24%   +0.14%     
==========================================
  Files          34       34              
  Lines        1327     1326       -1     
  Branches      390      392       +2     
==========================================
+ Hits         1262     1263       +1     
+ Misses         61       59       -2     
  Partials        4        4              
Impacted Files Coverage Δ
lib/Server.js 95.01% <100.00%> (+0.39%) ⬆️
lib/utils/DevServerPlugin.js 97.19% <100.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b0f514...15b1286. Read the comment docs.

@snitin315 snitin315 merged commit 2b53b00 into master Jun 10, 2021
@snitin315 snitin315 deleted the refactor-do-not-use-webpack-directly branch June 10, 2021 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants