Skip to content

Guides - Hot Module Replacement #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maheshpec opened this issue Jul 29, 2017 · 1 comment
Closed

Guides - Hot Module Replacement #1463

maheshpec opened this issue Jul 29, 2017 · 1 comment

Comments

@maheshpec
Copy link
Contributor

Hello,

While going through the hot module replacement guide, I noticed a snippet line did not have + sign indicating that its a new statement.

What is the current behavior?
HMR guide page's Gotcha section has a code snippet. This code snippet introduces a let element = component(); statement. Its not present in the Enabling HMR section. However, it does not have a + sign to indicate that its a new statement.

What is the expected behavior?
The let element = component(); statement should be treated as a new statement by having a + in front of it and highlighting it in green.

Thank you

@skipjack
Copy link
Collaborator

@maheshpec I'm going to close and quote your comment in #1461 as that one mentions this error as well. That way we can keep the discussion in one place. I think we may be able to update your PR with one or two other fixes to resolve these issues for good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants