Skip to content

Unexplained Code Change in Caching Guide #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
trautlein opened this issue Aug 13, 2017 · 3 comments
Closed

Unexplained Code Change in Caching Guide #1512

trautlein opened this issue Aug 13, 2017 · 3 comments
Labels
Correction Guides

Comments

@trautlein
Copy link

trautlein commented Aug 13, 2017 •
edited
Loading

On the caching guide page there is a change in the code that isn't noted or explained. The example goes from using [chunkhash] to [contenthash] without an explanation. The diff's in the documentation also don't show that this code has changed. I'm not sure why the change in the code occurs so I thought I would report it here.

The change happens inside the extracting boilerplate section.
@skipjack
Copy link
Collaborator

skipjack commented Aug 13, 2017 •
edited
Loading

This is a mistake. It should be chunkhash everywhere. contenthash is only used in the ExtractTextPlugin as far as I know. I thought this was fixed recently but maybe not all instances it were. Would you like to submit a PR?

skipjack added a commit that referenced this issue Aug 13, 2017
@skipjack
docs(guides): contenthash => chunkhash in caching
83bcf0e 
Correct this error in `output` configuration.

Fixes #1512
@skipjack skipjack mentioned this issue Aug 13, 2017
Merged
@trautlein
Copy link
Author

Totally would have but it looks like you beat me to it! Thanks for maintaining this docs so well!

@skipjack
Copy link
Collaborator

No problem, yeah it was a quick fix..

skipjack added a commit that referenced this issue Aug 13, 2017
@skipjack
docs(guides): contenthash => chunkhash in caching (#1517)
5cd03b9 
Correct this error in `output` configuration.

Fixes #1512
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Correction Guides
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trautlein @skipjack