Update hot-module-replacement.md #1456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missed lodash import
Merged
noticed there was this error when running the example : ERROR in chunk print [entry] build.js Conflict: Multiple assets emit to the same filename build.js
skipjack
reviewed
Jul 26, 2017
| @@ -213,7 +213,7 @@ __webpack.config.js__ | |||
| new webpack.HotModuleReplacementPlugin() | |||
| ], | |||
| output: { | |||
| filename: 'bundle.js', | |||
| filename: '[name].build.js', | |||
There was a problem hiding this comment.
I think [name].bundle.js is more commonly used than [name].build.js but I'm not sure if this is what is mentioned in the other guides. @TheDutchCoder do you know?
Personally I would prefer [name].bundle.js but I don't feel too strongly about it.
There was a problem hiding this comment.
You are right it should be [name].bundle.js that is what's on the other guides, will update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed the lodash import was missing in a index.js diff block