Long-term caching with Webpack 2 #661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bebraw
reviewed
Jan 18, 2017
|
|
||
| T> Separate your vendor and application code with [CommonsChunkPlugin](/plugins/commons-chunk-plugin) and create an explicit vendor chunk to prevent it from changing too often. | ||
| Webpack allows you to generate hashes depending on file contents, by replacing the placeholder `[hash]` with `[chunkhash]`. Here is the updated config: |
There was a problem hiding this comment.
/s/Webpack/webpack (it's in dev docs, this needs a linting rule).
There was a problem hiding this comment.
Updated Webpack to webpack. I also proof-read and updated the docs once more.
There was a problem hiding this comment.
Also, I agree about the linting rule. webpack as first word in sentences will probably often be written with a capital 'W'.
jouni-kantola
force-pushed
the
feature/deterministic-chunk-hashes
branch
from
8e96846 to
d1c1dad
Compare
|
@bebraw: What do you think about the title, |
|
@jouni-kantola thanks for doing this. It seems this PR would fix #677 that I opened as well. |
|
Thanks for the work. Further improvements can be handled through separate PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated description for long-term caching with Webpack 2
Addresses issues: #652 and webpack/webpack#1315