This repository was archived by the owner on May 13, 2024. It is now read-only.
add replaceTrack test #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
based on pc1 sample and the following two PRs: webrtc/samples#1009 webrtc/samples#996
henbos
approved these changes
Feb 28, 2018
| audio: true, | ||
| video: true | ||
| }) | ||
| .then(gotStream) |
There was a problem hiding this comment.
nit: Remove extra indentation of then()
There was a problem hiding this comment.
I agree with you but eslint does not sadly
| ).then( | ||
| onCreateOfferSuccess, | ||
| onCreateSessionDescriptionError | ||
| ); |
There was a problem hiding this comment.
Instead of a bunch of helper functions could this be more compactly written as?
try {
let offer = await pc1.createOffer();
await pc1.setLocalDescription(offer);
await pc2.setRemoteDescription(offer);
let answer = pc2.createAnswer();
await pc2.setLocalDescription(answer);
await pc1.setRemoteDescription(answer);
} catch (e) {
trace('Offer/Answer exchange failed: ' + e.message);
}
If more detailed error is desired, more try-catches or a variable keeping track of which stage we're at can be added.
There was a problem hiding this comment.
not sure how comfortable @KaptenJansson feels with es6 and async/await. But I wouldn't want to start the migration here and end up with a weird mix of styles
| ); | ||
| trace(getName(pc) + ' ICE candidate: \n' + (event.candidate ? | ||
| event.candidate.candidate : '(null)')); | ||
| } |
There was a problem hiding this comment.
How about using async function and await here too?
|
Ok LGTM still |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on pc1 sample and the following two PRs:
webrtc/samples#1009
webrtc/samples#996