Move base64 algorithms to Infra #2920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See whatwg/infra#145 for the change to the Infra Standard. Closes #2912.
domenic
approved these changes
Aug 15, 2017
|
|
||
| <!-- Aryeh says: Copies Firefox behavior as of January 2011 (4.0b8). WebKit is somewhat laxer, |
There was a problem hiding this comment.
Should we preserve this info, at least as comments, in the Infra copy? The mailing list link seems especially interesting.
There was a problem hiding this comment.
The reason I didn't is that all browsers pass the atob() tests, which tests all of this. So it would only be useful if we expect someone to try to remove that later on, but I guess it doesn't hurt either. I'll add that link back.
domenic
added
the
do not merge yet
annevk
added a commit
to whatwg/infra
that referenced
this pull request
Aug 15, 2017
For use by window.btoa()/window.atob() and soon data: URLs, see whatwg/fetch#579. Much of this text originated in the HTML Standard, see whatwg/html#2920 about removing that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See whatwg/infra#145 for the change to the Infra Standard.
Closes #2912.