-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Updated TFM of Notifications package from netcoreapp3.0 to netcoreapp3.1. #3383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks azchohfi for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
Interesting that even removing the installation of that sdk, it is still warning about it:
Its still building, and I think this is just a warning to make sure people see it, since once they remove it it might break builds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not familiar with the WPF-specific stuff, but the .NET Core and NuGet updates look good! 👍
@@ -19,6 +19,11 @@ | |||
<DefineConstants Condition="'$(DisableImplicitFrameworkDefines)' != 'true'">$(DefineConstants);WINRT</DefineConstants> | |||
</PropertyGroup> | |||
|
|||
<PropertyGroup Condition="'$(TargetFramework)' == 'net462'"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woah, hadn't noticed the toolkit was still supporting .NET Framework 4.6.2 too! 😄
I did those updates since, for some bizarre reason, the Pages' *.g.cs were not being added properly when I did this change (no idea why). This small change is now using the UseWpf property(which makes them build fine), and I'm turning the automatic inclusion of pages off, since the Directory.Build.props is already adding them: |
Fixes #3382
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Microsoft.Toolkit.Uwp.Notifications targets an end of life SDK (netcoreapp3.0). We should upgrade it to netcoreapp3.1.
What is the new behavior?
Microsoft.Toolkit.Uwp.Notifications targets netcoreapp3.1.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
I've also fixed a small race condition on the tests, since they run on parallel, per class, and two classes/tests were writing to the same file, which would eventually fail.