-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix Debug AnyCPU config for XamlIslands Package Unit Test #3601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix Debug AnyCPU config for XamlIslands.Package unit test project so it builds x86.
Thanks alvinashcraft for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
Hello @michael-hawker! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 7 hours 37 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
@msftbot merge if @azchohfi approves. |
Hello @michael-hawker! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
@azchohfi I've noticed VS has been trying to remove some of the I just generally wish this whole system wasn't based on GUIDs... Why couldn't have these just all been in a comma list under the project path link itself...? |
We don't have the native configurations anymore. That was for the old C++ Gaze project we had. If its removing it, its fine. |
Fix Debug AnyCPU config for XamlIslands.Package unit test project so it builds for x86.
Fixes
Fixes #3599
Updated the Debug|AnyCPU config for UnitTests.XamlIslands.Package to build for x86. This is what it was doing for Release|AnyCPU.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Build fails for Debug|AnyCPU
What is the new behavior?
Build succeeds for Debug|AnyCPU
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
VS2019 rearranged a bunch of the other project configs in the solution file. Feel free to reject everything but the changes on lines 751-753.