Respect sameSite while deleting cookie #255
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mintuhouse
force-pushed
the
mintuhouse/fix-logout-iframe
branch
from
7dc26f2 to
4c62373
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the logout behavior from inside an iframe by respecting the sameSite policy when deleting the cookie.
- Adds an import for WORKOS_COOKIE_SAMESITE.
- Sets sameSite (defaulting to 'lax') and computes the secure flag based on sameSite before deleting the cookie.
|
@nicknisi can you review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for logout when using from inside an iframe
Fixes #243 (comment)
Redo of #232