Skip to content

Small fixes in README.namelist regarding MYNN scheme #2220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

MHBalsmeier
Copy link

@MHBalsmeier MHBalsmeier commented May 4, 2025

TYPE: bugfix, text only

KEYWORDS: README, namelist, default, MYNN

SOURCE: Max Balsmeier

DESCRIPTION OF CHANGES:
Problem:
The default for namelist bl_mynn_mixlength was wrong and the definition of bl_mynn_cloudmix was not clear for MYNN PBL.

Solution:
The README was fixed and clarified.

LIST OF MODIFIED FILES: run/README.namelist

RELEASE NOTE: Fix and clarification in README.namelist regarding MYNN PBL scheme.

@MHBalsmeier MHBalsmeier requested a review from a team as a code owner May 4, 2025 23:14
@islas islas changed the base branch from develop to release-v4.7.1 May 5, 2025 21:12
dudhia
dudhia previously requested changes May 7, 2025
Copy link
Collaborator

@dudhia dudhia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant the bl_mynn_closure section which is in the middle of the PBL options. It should be moved with the other bl_mynn options. Sorry this was for another PR. Please ignore.

@weiwangncar
Copy link
Collaborator

@joeolson42 Can you review this PR? Thanks!

@weiwangncar
Copy link
Collaborator

@islas Can we modify Jimy's comment so that the requested change is removed?

@islas islas dismissed dudhia’s stale review May 30, 2025 02:44

Requested change dismissed

@islas
Copy link
Collaborator

islas commented May 30, 2025

I approved in lieu of @joeolson42 as the review needed to be from someone with write access to count as one of the two required

@weiwangncar
Copy link
Collaborator

@islas Thanks and this PR should be ready to be merged.

@islas islas merged commit e6472cb into wrf-model:release-v4.7.1 May 30, 2025
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants