Skip to content

Fix vlucas/phpdotenv (broken after update to 3.3). #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

tormi
Copy link
Member

@tormi tormi commented Apr 30, 2019

Problem

Site builder is broken after #47. lando start > URL gives following error on fresh site:

Fatal error: Uncaught TypeError: Argument 1 passed to Dotenv\Dotenv::__construct() must be an instance of Dotenv\Loader, string given, called in /app/load.environment.php on line 14 and defined in /app/vendor/vlucas/phpdotenv/src/Dotenv.php:31 Stack trace: #0 /app/load.environment.php(14): Dotenv\Dotenv->__construct('/app') #1 /app/vendor/composer/autoload_real.php(66): require('/app/load.envir...') #2 /app/vendor/composer/autoload_real.php(56): composerRequire599efd37580279d6a016b0ec99c4e8aa('b31eeea3e696c9a...', '/app/vendor/com...') #3 /app/vendor/autoload.php(7): ComposerAutoloaderInit599efd37580279d6a016b0ec99c4e8aa::getLoader() #4 /app/web/autoload.php(17): require('/app/vendor/aut...') #5 /app/web/index.php(14): require_once('/app/web/autolo...') #6 {main} thrown in /app/vendor/vlucas/phpdotenv/src/Dotenv.php on line 31

Solution

Fix upgrade vlucas/phpdotenv V2 to V3: https://github.com/vlucas/phpdotenv/blob/master/UPGRADING.md

@tormi tormi self-assigned this Apr 30, 2019
@tormi tormi requested a review from floretan April 30, 2019 05:47
@tormi
Copy link
Member Author

tormi commented Apr 30, 2019

Did also PR in upstream: drupal-composer/drupal-project#487

@floretan floretan merged commit d719030 into master Apr 30, 2019
@floretan
Copy link
Contributor

Nice work!

@floretan floretan deleted the feature/fix-vlucas-phpdotenv branch April 30, 2019 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants