[READY] Update Go completer #1098

micbou · 2018-09-04T12:44:41Z

As discussed in issue #1097, switch the Gocode version to mdempsky's fork. This requires moving the Gocode submodule to third_party/go/src/github.com/mdempsky/gocode and setting GOPATH to third_party/go when building Gocode. Do the same for Godef. This way, using Manishearth's fork is not needed anymore.

The following changes to the Go completer are required with this new version of Gocode:

the status endpoint has been removed so the server is now assumed to be healthy if it's running;
the null response is returned when there are no completions.

Closes #1090.
Closes #1092.
Closes #1097.

This change is

Switch Gocode to mdempsky's fork and use the official repository for Godef. Move Gocode and Godef submodules to third_party/go/src/github.com to allow building them in place. Since the status endpoint has been removed from Gocode, assume the server is healthy if it's running. Handle a null response from Gocode.

bstaletic

Generally, this is , but we should somehow remember to update gocode again, once go modules are supported.

Reviewed 9 of 9 files at r1.
Reviewable status: 0 of 2 LGTMs obtained (and 1 stale)

codecov · 2018-09-04T18:27:58Z

Codecov Report

Merging #1098 into master will increase coverage by 1.25%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1098      +/-   ##
==========================================
+ Coverage   96.31%   97.56%   +1.25%     
==========================================
  Files          89       89              
  Lines        6624     6948     +324     
==========================================
+ Hits         6380     6779     +399     
+ Misses        244      169      -75

flowchartsman · 2018-09-07T05:51:11Z

Please merge this change and roll a release, it's making my days full of headaches.

bstaletic · 2018-09-07T07:16:17Z

@flowchartsman We have a rule that requires two LGTM's from two team members before we merge any PR.

If you really need this PR merged, do the following:

cd /path/to/YouCompleteMe/third_party/ycmd
git checkout master
git pull
git fetch origin +refs/pull/1098/merge
git checkout FETCH_HEAD
Rebuild what's necessary.

flowchartsman · 2018-09-07T12:28:54Z

Sure. In the meantime, I'll venmo 50$ to whomever LGTMs and lands this. I do really need it :)

puremourning · 2018-09-08T08:28:23Z

We’re doing this in our spare time (see CONTRIBUTING.md). I don’t have a lot of that right now sorry so there has been a delay. I will try to get to it today but nagging doesn’t really help.

flowchartsman · 2018-09-08T18:46:14Z

Not nagging, showing appreciation for volunteer work. I’m not familiar enough with the codebase to do it myself, and it’s wrong to ask for a priority without offering to compensate to an expert, but if you find that it cheapens the work, I will find another way to contribute towards the project. Thanks in advance.

…

Sent from my iPhone

On Sep 8, 2018, at 4:28 AM, Ben Jackson ***@***.***> wrote: We’re doing this in our spare time (see CONTRIBUTING.md). I don’t have a lot of that right now sorry so there has been a delay. I will try to get to it today but nagging doesn’t really help. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

puremourning

LGTM sorry for the delay.

Reviewable status: 1 of 2 LGTMs obtained

micbou · 2018-09-09T01:41:30Z

Thanks for the review.

@zzbot r+

zzbot · 2018-09-09T01:41:30Z

📌 Commit 2b3e1cf has been approved by micbou

zzbot · 2018-09-09T01:41:33Z

⌛ Testing commit 2b3e1cf with merge 10dc665...

[READY] Update Go completer As discussed in issue #1097, switch the Gocode version to [mdempsky's fork](https://github.com/mdempsky/gocode). This requires moving the Gocode submodule to `third_party/go/src/github.com/mdempsky/gocode` and setting `GOPATH` to `third_party/go` when building Gocode. Do the same for Godef. This way, using [Manishearth's fork](https://github.com/Manishearth/godef) is not needed anymore. The following changes to the Go completer are required with this new version of Gocode: - the `status` endpoint has been removed so the server is now assumed to be healthy if it's running; - the `null` response is returned when there are no completions. Closes #1090. Closes #1092. Closes #1097.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/1098)

Valloric

A bit late, but from me as well.

Reviewable status: 1 of 2 LGTMs obtained (and 1 stale)

zzbot · 2018-09-09T03:11:10Z

☀️ Test successful - status-appveyor, status-travis
Approved by: micbou
Pushing 10dc665 to master...

[READY] Update ycmd Include the following changes: - PR ycm-core/ycmd#1075: remove Node.js workaround for Debian-based distributions; - PR ycm-core/ycmd#1077: update Boost to 1.68; - PR ycm-core/ycmd#1078: add semantic trigger for Julia; - PR ycm-core/ycmd#1081: improve type information on C++ member functions; - PR ycm-core/ycmd#1086: check if Python headers are installed before building; - PR ycm-core/ycmd#1088: raise proper exception for commands when file is still being parsed in C-family languages; - PR ycm-core/ycmd#1098: update Go completer; - PR ycm-core/ycmd#1099: update regex submodule; - PR ycm-core/ycmd#1100: add Python path to debugging information; - PR ycm-core/ycmd#1103: support framework headers completion and code navigation in C-family languages; - PR ycm-core/ycmd#1107: update Clang to 7.0.0; - PR ycm-core/ycmd#1109: update jdt.ls to 0.25.0; - PR ycm-core/ycmd#1110: handle null hover response from language servers; - PR ycm-core/ycmd#1111: update list of completion kinds defined by LSP; - PR ycm-core/ycmd#1113: send completion item kinds capability to language servers; - PR ycm-core/ycmd#1116: update Parso to 0.3.1 and Jedi to 0.13.1. Closes #3138. Closes #3145.  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/3175)

This was referenced Sep 4, 2018

[READY] Fix Gocode tests on CI services #1090

Closed

Official gocode is not supported anymore #1097

Closed

micbou force-pushed the update-gocode branch 2 times, most recently from 11bd8fe to 325dd53 Compare September 4, 2018 12:50

micbou force-pushed the update-gocode branch from 325dd53 to 2b3e1cf Compare September 4, 2018 12:51

micbou mentioned this pull request Sep 4, 2018

Move to maintained version of Gocode ycm-core/YouCompleteMe#3138

Closed

bstaletic approved these changes Sep 4, 2018

View reviewed changes

This was referenced Sep 5, 2018

YCM not working with Golang ycm-core/YouCompleteMe#3074

Closed

Update submodule from nsf/gocode to mdempsky/gocode #1092

Closed

puremourning approved these changes Sep 9, 2018

View reviewed changes

Valloric approved these changes Sep 9, 2018

View reviewed changes

zzbot merged commit 2b3e1cf into ycm-core:master Sep 9, 2018

micbou mentioned this pull request Sep 18, 2018

go_completer.py should perhaps expect to get literal null from gocode ycm-core/YouCompleteMe#3145

Closed

7 tasks

micbou mentioned this pull request Oct 7, 2018

[READY] Update ycmd ycm-core/YouCompleteMe#3175

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[READY] Update Go completer #1098

[READY] Update Go completer #1098

Uh oh!

micbou commented Sep 4, 2018 •

edited by Valloric

Loading

Uh oh!

bstaletic left a comment

Uh oh!

codecov bot commented Sep 4, 2018 •

edited

Loading

Uh oh!

flowchartsman commented Sep 7, 2018

Uh oh!

bstaletic commented Sep 7, 2018

Uh oh!

flowchartsman commented Sep 7, 2018 •

edited

Loading

Uh oh!

puremourning commented Sep 8, 2018

Uh oh!

flowchartsman commented Sep 8, 2018 via email

Uh oh!

puremourning left a comment

Uh oh!

micbou commented Sep 9, 2018

Uh oh!

zzbot commented Sep 9, 2018

Uh oh!

zzbot commented Sep 9, 2018

Uh oh!

Valloric left a comment

Uh oh!

zzbot commented Sep 9, 2018

Uh oh!

Uh oh!

[READY] Update Go completer #1098

[READY] Update Go completer #1098

Uh oh!

Conversation

micbou commented Sep 4, 2018 • edited by Valloric Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bstaletic left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Sep 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

flowchartsman commented Sep 7, 2018

Uh oh!

bstaletic commented Sep 7, 2018

Uh oh!

flowchartsman commented Sep 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

puremourning commented Sep 8, 2018

Uh oh!

flowchartsman commented Sep 8, 2018 via email

Uh oh!

puremourning left a comment

Choose a reason for hiding this comment

Uh oh!

micbou commented Sep 9, 2018

Uh oh!

zzbot commented Sep 9, 2018

Uh oh!

zzbot commented Sep 9, 2018

Uh oh!

Valloric left a comment

Choose a reason for hiding this comment

Uh oh!

zzbot commented Sep 9, 2018

Uh oh!

Uh oh!

micbou commented Sep 4, 2018 •

edited by Valloric

Loading

codecov bot commented Sep 4, 2018 •

edited

Loading

flowchartsman commented Sep 7, 2018 •

edited

Loading