Skip to content

fix shared_ptr extraction from PortionsToAccess #15009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

swalrus1
Copy link
Collaborator

@swalrus1 swalrus1 commented Feb 25, 2025

Changelog entry

Fix shared_ptr extraction from PortionsToAccess on CS #13514

Changelog category

  • Bugfix

Description for reviewers

Copy link

github-actions bot commented Feb 25, 2025

🟢 2025-02-25 14:22:52 UTC The validation of the Pull Request description is successful.

@github-actions github-actions bot added bugfix and removed bugfix labels Feb 25, 2025
Copy link

github-actions bot commented Feb 25, 2025

2025-02-25 13:23:54 UTC Pre-commit check linux-x86_64-release-asan for 7bed755 has started.
2025-02-25 13:25:03 UTC Artifacts will be uploaded here
2025-02-25 13:28:03 UTC ya make is running...
🟡 2025-02-25 14:38:45 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11615 11515 0 58 8 34

2025-02-25 14:39:54 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-25 14:54:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
149 (only retried tests) 112 0 2 3 32

2025-02-25 14:55:11 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-02-25 15:07:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
66 (only retried tests) 32 0 2 2 30

🟢 2025-02-25 15:07:24 UTC Build successful.
🟢 2025-02-25 15:07:59 UTC ydbd size 3.6 GiB changed* by -352 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 9029d02 merge: 7bed755 diff diff %
ydbd size 3 900 116 896 Bytes 3 900 116 544 Bytes -352 Bytes -0.000%
ydbd stripped size 1 365 335 376 Bytes 1 365 335 248 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 25, 2025

2025-02-25 13:24:00 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7bed755 has started.
2025-02-25 13:24:16 UTC Artifacts will be uploaded here
2025-02-25 13:27:12 UTC ya make is running...
🟡 2025-02-25 14:29:23 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18851 17471 0 8 1234 138

2025-02-25 14:31:12 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-25 14:58:50 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
233 (only retried tests) 99 0 3 2 129

2025-02-25 14:58:59 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-02-25 15:11:06 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
198 (only retried tests) 67 0 3 1 127

🟢 2025-02-25 15:11:14 UTC Build successful.
🟢 2025-02-25 15:11:43 UTC ydbd size 2.1 GiB changed* by -128 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 9029d02 merge: 7bed755 diff diff %
ydbd size 2 243 209 832 Bytes 2 243 209 704 Bytes -128 Bytes -0.000%
ydbd stripped size 474 901 528 Bytes 474 901 528 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@swalrus1 swalrus1 marked this pull request as ready for review February 25, 2025 13:43
@swalrus1 swalrus1 requested a review from a team as a code owner February 25, 2025 13:43
@github-actions github-actions bot added bugfix and removed bugfix labels Feb 25, 2025
@swalrus1 swalrus1 changed the title prevent shared_ptr loop fix shared_ptr extraction from PortionsToAccess Feb 25, 2025
@github-actions github-actions bot added bugfix and removed bugfix labels Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant