Skip to content

Fix not consistent generation counters for data erasure in SchemeShard tablet and BSC tablet #19019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 3, 2025
Merged

Fix not consistent generation counters for data erasure in SchemeShard tablet and BSC tablet #19019

merged 4 commits into from
Jun 3, 2025

Conversation

molotkov-and
Copy link
Collaborator

@molotkov-and molotkov-and commented May 29, 2025 •
edited
Loading

Changelog entry

Fix not consistent generation counters for data erasure in SchemeShard tablet and BSC tablet

Changelog category

  • Bugfix

Description for reviewers

#18739
Add separate counter for BSC. Made generation counter in SchemeS hard consist with generation counter in BSC.

@molotkov-and molotkov-and requested a review from a team as a code owner May 29, 2025 12:39
@github-actions GitHub Actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

🟢 2025-05-29 12:40:17 UTC The validation of the Pull Request description is successful.

@github-actions github-actions bot added bugfix and removed bugfix labels May 29, 2025
@molotkov-and molotkov-and requested review from ijon and removed request for ijon May 29, 2025 12:40
@github-actions GitHub Actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

⚪ 2025-05-29 12:40:54 UTC Pre-commit check linux-x86_64-release-asan for c3cfcfb has started.
⚪ 2025-05-29 12:41:05 UTC Artifacts will be uploaded here
⚪ 2025-05-29 12:44:07 UTC ya make is running...
🟡 2025-05-29 14:19:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13772 13590 0 87 72 23

⚪ 2025-05-29 14:20:35 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-29 14:53:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
2201 (only retried tests) 2114 0 61 7 19

⚪ 2025-05-29 14:54:19 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-29 15:23:39 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1282 (only retried tests) 1203 0 53 6 20

🟢 2025-05-29 15:23:54 UTC Build successful.
🔴 2025-05-29 15:24:23 UTC ydbd size 3.9 GiB changed* by +7.3 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: c3cfcfb diff diff %
ydbd size 4 147 273 176 Bytes 4 154 929 952 Bytes +7.3 MiB +0.185%
ydbd stripped size 1 440 065 016 Bytes 1 442 220 472 Bytes +2.1 MiB +0.150%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

⚪ 2025-05-29 12:40:54 UTC Pre-commit check linux-x86_64-relwithdebinfo for c3cfcfb has started.
⚪ 2025-05-29 12:41:05 UTC Artifacts will be uploaded here
⚪ 2025-05-29 12:43:57 UTC ya make is running...
🟡 2025-05-29 14:00:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21746 20353 0 17 1337 39

⚪ 2025-05-29 14:02:24 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-29 14:34:33 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
378 (only retried tests) 339 0 9 0 30

⚪ 2025-05-29 14:34:42 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-05-29 15:12:59 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
356 (only retried tests) 331 0 1 0 24

🟢 2025-05-29 15:13:07 UTC Build successful.
🔴 2025-05-29 15:13:30 UTC ydbd size 2.2 GiB changed* by +4.0 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: c3cfcfb diff diff %
ydbd size 2 358 248 400 Bytes 2 362 423 888 Bytes +4.0 MiB +0.177%
ydbd stripped size 495 390 920 Bytes 496 026 216 Bytes +620.4 KiB +0.128%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@molotkov-and molotkov-and linked an issue May 29, 2025 that may be closed by this pull request
Coordinate independence counters in SchemeShard and BS controller #18739
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

⚪ 2025-05-30 13:06:09 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4b65f17 has started.
⚪ 2025-05-30 13:06:20 UTC Artifacts will be uploaded here
⚪ 2025-05-30 13:09:19 UTC ya make is running...
🟡 2025-05-30 14:19:23 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21746 20365 0 5 1337 39

⚪ 2025-05-30 14:21:12 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-30 14:58:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
463 (only retried tests) 427 0 1 0 35

⚪ 2025-05-30 14:58:32 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-05-30 15:43:46 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
414 (only retried tests) 377 0 0 0 37

🟢 2025-05-30 15:43:55 UTC Build successful.
🟢 2025-05-30 15:44:13 UTC ydbd size 2.2 GiB changed* by +11.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3cd2e23 merge: 4b65f17 diff diff %
ydbd size 2 362 413 864 Bytes 2 362 425 760 Bytes +11.6 KiB +0.001%
ydbd stripped size 496 024 936 Bytes 496 026 600 Bytes +1.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

⚪ 2025-05-29 15:58:16 UTC Pre-commit check linux-x86_64-release-asan for 4b65f17 has started.
⚪ 2025-05-29 15:58:27 UTC Artifacts will be uploaded here
⚪ 2025-05-29 16:01:25 UTC ya make is running...
🟡 2025-05-29 17:41:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13771 13593 0 90 64 24

⚪ 2025-05-29 17:42:24 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-29 18:10:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1372 (only retried tests) 1291 0 51 9 21

⚪ 2025-05-29 18:10:43 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-29 18:41:20 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1597 (only retried tests) 1512 0 50 11 24

🟢 2025-05-29 18:41:36 UTC Build successful.
🔴 2025-05-29 18:42:06 UTC ydbd size 3.9 GiB changed* by +7.3 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: d617cc1 merge: 4b65f17 diff diff %
ydbd size 4 147 273 176 Bytes 4 154 931 000 Bytes +7.3 MiB +0.185%
ydbd stripped size 1 440 065 016 Bytes 1 442 221 048 Bytes +2.1 MiB +0.150%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2025 •
edited
Loading

⚪ 2025-06-03 13:28:15 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7e50f78 has started.
⚪ 2025-06-03 13:28:19 UTC Artifacts will be uploaded here
⚪ 2025-06-03 13:31:18 UTC ya make is running...
🟡 2025-06-03 14:30:23 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
21758 20383 0 4 1339 32

⚪ 2025-06-03 14:32:23 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-03 14:55:40 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
515 (only retried tests) 486 0 1 0 28

⚪ 2025-06-03 14:55:51 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-06-03 15:12:24 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
438 (only retried tests) 412 0 0 0 26

🟢 2025-06-03 15:12:35 UTC Build successful.
🟢 2025-06-03 15:12:58 UTC ydbd size 2.2 GiB changed* by +4.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 33b7f67 merge: 7e50f78 diff diff %
ydbd size 2 364 337 896 Bytes 2 364 342 264 Bytes +4.3 KiB +0.000%
ydbd stripped size 496 324 520 Bytes 496 325 608 Bytes +1.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2025 •
edited
Loading

⚪ 2025-06-03 13:28:22 UTC Pre-commit check linux-x86_64-release-asan for 7e50f78 has started.
⚪ 2025-06-03 13:28:33 UTC Artifacts will be uploaded here
⚪ 2025-06-03 13:31:38 UTC ya make is running...
🟡 2025-06-03 15:13:01 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13773 13546 0 89 114 24

⚪ 2025-06-03 15:14:11 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-03 15:50:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1993 (only retried tests) 1907 0 61 6 19

⚪ 2025-06-03 15:50:45 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-03 16:20:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1391 (only retried tests) 1272 0 64 34 21

🟢 2025-06-03 16:20:33 UTC Build successful.
🟢 2025-06-03 16:21:10 UTC ydbd size 3.9 GiB changed* by +7.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 33b7f67 merge: 7e50f78 diff diff %
ydbd size 4 158 103 776 Bytes 4 158 111 368 Bytes +7.4 KiB +0.000%
ydbd stripped size 1 442 980 216 Bytes 1 442 983 160 Bytes +2.9 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@molotkov-and molotkov-and merged commit 6079d14 into ydb-platform:main Jun 3, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijon ijon ijon approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coordinate independence counters in SchemeShard and BS controller
2 participants
@molotkov-and @ijon