Skip to content

Fixed the deletion of blobs by retention in the supportive partition of the topic #19916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nshestakov
Copy link
Collaborator

@nshestakov nshestakov commented Jun 19, 2025

Changelog entry

If writing is done to the topic using a transaction and the retention of messages in the topic is less than the duration of the transaction, then inconsistent data could be written to the partition.

Changelog category

  • Bugfix

Description for reviewers

LOGBROKER-9723

@nshestakov nshestakov requested review from a team and snaury as code owners June 19, 2025 15:11
@nshestakov nshestakov changed the base branch from main to stable-25-1-2 June 19, 2025 15:12
@nshestakov nshestakov requested a review from a team as a code owner June 19, 2025 15:12
@nshestakov nshestakov changed the title Tx fix retention 25 1 2 Fixed cleanup supprotive partition Jun 19, 2025
Copy link

github-actions bot commented Jun 19, 2025

🟢 2025-06-19 16:14:44 UTC The validation of the Pull Request description is successful.

@nshestakov nshestakov changed the title Fixed cleanup supprotive partition Fixed the deletion of blobs by retention in the supportive partition of the topic Jun 19, 2025
@nshestakov nshestakov added the rebase-and-check Rebase PR with the current base branch and check label Jun 19, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jun 19, 2025
Copy link

github-actions bot commented Jun 19, 2025

2025-06-19 16:03:10 UTC Pre-commit check linux-x86_64-release-asan for 33cbf30 has started.
2025-06-19 16:03:22 UTC Artifacts will be uploaded here
2025-06-19 16:06:22 UTC ya make is running...
🟡 2025-06-19 17:21:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12370 12199 0 69 67 35

2025-06-19 17:22:52 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-19 17:43:27 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
220 (only retried tests) 122 0 8 57 33

2025-06-19 17:43:36 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-19 18:03:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
127 (only retried tests) 40 0 8 46 33

🟢 2025-06-19 18:03:47 UTC Build successful.
🟢 2025-06-19 18:04:17 UTC ydbd size 3.7 GiB changed* by +112 Bytes, which is < 100.0 KiB vs stable-25-1-2: OK

ydbd size dash stable-25-1-2: 356c61b merge: 33cbf30 diff diff %
ydbd size 3 927 693 696 Bytes 3 927 693 808 Bytes +112 Bytes +0.000%
ydbd stripped size 1 373 423 216 Bytes 1 373 423 216 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jun 19, 2025

2025-06-19 16:03:32 UTC Pre-commit check linux-x86_64-relwithdebinfo for 33cbf30 has started.
2025-06-19 16:03:43 UTC Artifacts will be uploaded here
2025-06-19 16:06:32 UTC ya make is running...
🟡 2025-06-19 17:05:46 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19423 18144 0 6 1211 62

2025-06-19 17:07:36 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-19 17:27:47 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
133 (only retried tests) 68 0 1 5 59

2025-06-19 17:27:55 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-06-19 17:47:48 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
119 (only retried tests) 56 0 0 4 59

🟢 2025-06-19 17:47:58 UTC Build successful.
🟢 2025-06-19 17:48:21 UTC ydbd size 2.1 GiB changed* by +48 Bytes, which is < 100.0 KiB vs stable-25-1-2: OK

ydbd size dash stable-25-1-2: 356c61b merge: 33cbf30 diff diff %
ydbd size 2 257 908 752 Bytes 2 257 908 800 Bytes +48 Bytes +0.000%
ydbd stripped size 477 952 856 Bytes 477 952 856 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nshestakov nshestakov removed request for a team June 19, 2025 17:46
@nshestakov nshestakov removed request for a team, snaury, pixcc and FloatingCrowbar June 19, 2025 17:46
Copy link

github-actions bot commented Jun 20, 2025

2025-06-20 05:37:47 UTC Pre-commit check linux-x86_64-release-asan for 0e06576 has started.
2025-06-20 05:37:59 UTC Artifacts will be uploaded here
2025-06-20 05:40:53 UTC ya make is running...
🟡 2025-06-20 06:54:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12370 12223 0 50 62 35

2025-06-20 06:55:25 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-20 07:16:02 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
198 (only retried tests) 100 0 7 57 34

2025-06-20 07:16:10 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-20 07:35:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
127 (only retried tests) 33 0 7 54 33

🟢 2025-06-20 07:36:06 UTC Build successful.
🟢 2025-06-20 07:36:38 UTC ydbd size 3.7 GiB changed* by +112 Bytes, which is < 100.0 KiB vs stable-25-1-2: OK

ydbd size dash stable-25-1-2: 10071e0 merge: 0e06576 diff diff %
ydbd size 3 927 693 696 Bytes 3 927 693 808 Bytes +112 Bytes +0.000%
ydbd stripped size 1 373 423 216 Bytes 1 373 423 216 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jun 20, 2025

2025-06-20 05:37:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0e06576 has started.
2025-06-20 05:38:00 UTC Artifacts will be uploaded here
2025-06-20 05:40:49 UTC ya make is running...
🟡 2025-06-20 06:42:48 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19423 18149 0 5 1209 60

2025-06-20 06:44:41 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-06-20 07:05:49 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
127 (only retried tests) 68 0 0 1 58

🟢 2025-06-20 07:05:59 UTC Build successful.
🟢 2025-06-20 07:06:17 UTC ydbd size 2.1 GiB changed* by +48 Bytes, which is < 100.0 KiB vs stable-25-1-2: OK

ydbd size dash stable-25-1-2: 10071e0 merge: 0e06576 diff diff %
ydbd size 2 257 908 752 Bytes 2 257 908 800 Bytes +48 Bytes +0.000%
ydbd stripped size 477 952 856 Bytes 477 952 856 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@nshestakov nshestakov enabled auto-merge June 20, 2025 09:11
@nshestakov nshestakov merged commit a11a66f into ydb-platform:stable-25-1-2 Jun 20, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants