Skip to content

refactor: reduce bundle size #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/pico.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ function defineDynamicClass(): {
}

class Pico extends defineDynamicClass() {
private routes: {
private r: {
pattern: URLPattern
method: string
handler: Handler
Expand All @@ -30,7 +30,7 @@ class Pico extends defineDynamicClass() {
method: method.toLowerCase(),
handler,
}
this.routes.push(route)
this.r.push(route)
return this
}

Expand All @@ -39,7 +39,7 @@ class Pico extends defineDynamicClass() {
url: string
): { handler: Handler; result: URLPatternURLPatternResult } {
method = method.toLowerCase()
for (const route of this.routes) {
for (const route of this.r) {
const match = route.pattern.exec(url)
if ((match && route.method === 'all') || (match && route.method === method)) {
return { handler: route.handler, result: match }
Expand Down