Pull request against v3.4.4-rc (6bc0a7f3e722d1f0f40f832ac7650e606e9b158b) from refactor/remove-maptools #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* de-duplicate contours * Add de-duplication test * Add NEWS bullet
* Apply alignment panel-wise instead of globally * Add NEWS bullets * Add unit test
* Update `coord_flip()` docs * Communicate `coord_flip()` as superseded
* Connect scales to aes documentation * Improvements to aes documentation * Crosslink aes documentation * Match aes to doc page * Prevent having to import `relist()` * Better crosslinks for position scales * Roxygenate * Add NEWS bullet * Fix clumsy merge * Fix clumsy merge part II
* Don't drop groups in stat_ydensity * Add `drop` argument as switch * Add test * Add NEWS bullet
* `geom_bar()` uses panelwise resolution * Add test * Add NEWS bullet
* Repair arrows in `!constant` branch * Add arrow repair tests * Add NEWS bullet * Move NEWS bullet
* mapped_discrete has resolution 1 * Add resolution test * Add NEWS bullet
Release 3.4.2
* Test for presence/absence instead of size * Add test
* Make sure you have ticks before trying to plot them * Add NEWS bullet
* Add type check to `theme_set()` * Include test snapshot
* Expose `geom_dotplot()`'s 'weight' aesthetic * `stat_ydensity()` drops weight
* Export `translate_shape_string()` * Add NEWS bullet
* Add constant check
* Exclude geom_{ab/h/v}line from check
* Add test
* Pass constructor as call in warning
* Don't squish to zero-range domains * Add test battery
* Update message * Update tests
* reimplement titleGrob * strips don't adjust titleGrob's viewports * Further simplification * accept rounding errors in visual tests * Simplify `assemble_strips()` * Add back debug rectangles * Add (back) comments * Retire functions that are no longer needed * Add code review suggestions * Leave news bullet for extension maintainers
* Use `angle` aesthetic in `geom_label()` * Add news bullet * Revert unnecessary clip argument * Add rotation test * Update docs * Use text descenders * Interpret "lines" unit correctly * Accept visual change * Update news bullet * Use titleGrob for label * Allow margin as padding * Decommission makeContent method * Edit NEWS bullet * Update test * improve details
* Convert `scales_*()` functions to ScalesList methods * Use ScalesList methods instead of functions * Decommission `scales_*()` functions
The guide system, as the last remaining chunk of ggplot2, has been rewritten in ggproto. The axes and legends now inherit from a <Guide> class, which makes them extensible in the same manner as geoms, stats, facets and coords (tidyverse#3329, @teunbrand). In addition, the following changes were made: * Styling theme parts of the guide now inherit from the plot's theme (tidyverse#2728). * Styling non-theme parts of the guides accept <element> objects, so that the following is possible: `guide_colourbar(frame = element_rect(...))`. * Primary axis titles are now placed at the primary guide, so that `guides(x = guide_axis(position = "top"))` will display the title at the top by default (tidyverse#4650). * Unknown secondary axis guide positions are now inferred as the opposite of the primary axis guide when the latter has a known `position` (tidyverse#4650). * `guide_colourbar()`, `guide_coloursteps()` and `guide_bins()` gain a `ticks.length` argument. * In `guide_bins()`, the title no longer arbitrarily becomes offset from the guide when it has long labels. * The `order` argument of guides now strictly needs to be a length-1 integer (tidyverse#4958). * More informative error for mismatched `direction`/`theme(legend.direction = ...)` arguments (tidyverse#4364, tidyverse#4930). * `guide_coloursteps()` and `guide_bins()` sort breaks (tidyverse#5152).
* Handle `labels = NULL` better * Convert `guides()` error to warning * Ignore no guides * Swap old train order * Fix `even.steps`/`show.limits` interaction * Change to soft deprecation * Fix old guide title * Fix `draw_axis()` with `NULL` labels * Default old guide title is `waiver()` * `guide_for_position` becomes <Guides> method * GuideColoursteps is a named class * `guide_colourbar()` rejects discrete scales * Fix test TODO * Use `vec_slice()` to preserve attributes * Document extension points * Handle hashing in `train()`
* Add `outliers` param to boxplot * Add test * Redocument * Add news bullet
* Key size accounts for linewidth * Add test * Add bullet
* Preserve aesthetics in colourbar merge
Release 3.4.3
* Implement staples * Document * Add test * Add check for staplewidth * Fix typo
…_distiller's non-intuitive "direction" (tidyverse#5381) * Update scale-brewer.R Capturing in documentation that scale_*_distiller has a non-intuitive default direction = -1, and that to reverse, user needs to specify direction = 1 Source: tidyverse#1439 tidyverse#4444 * Move comment from Details to Note * Document --------- Co-authored-by: yutannihilation <[email protected]>
* Draft introduction vignette * Fix index entry * Add as pkgdown article * Apply suggestions from code review Co-authored-by: Mine Cetinkaya-Rundel <[email protected]> * move mapping to main call * `displ` -> `cty` * Add cake * `coord_polar()` -> `coord_fixed()` * `vars()` -> formula * Show stacking layers early on * Rephrase what a mapping does * Misc. tinkering * Rename * things -> alterations * Add alt text * Unlist from pkgdown * Apply suggestions from code review Co-authored-by: Mine Cetinkaya-Rundel <[email protected]> * Incorporate review suggestions --------- Co-authored-by: Mine Cetinkaya-Rundel <[email protected]>
* Preserve mapped_discrete class * Add test * Add news bullet
* Allow rel in element tree * Allow combining of rel elements * Add test * Add news bullet * Fix test for pre-R4.0.0 units * Also apply `rel` to numerics
* More informative calls in constructors * Add test for scale calls * Fix call for feed-forward scales * Fix calls for gnarly default scales * Fix calls for transformation scales * Reoxygenate * Supply `call` to messages * Accept periods at ends of messages * Forward calls to checkers * Fix tidyverse#4258 * `find_scale()` generates call * `xlim`/`ylim` have appropriate calls * `check_transformation()` throws more informative warning * Remove orphaned code * Deprecate `scale_name` argument * Purge `scale_name` * Test deprecation messages * Add NEWS bullet * conditionally test time scales
…yverse#5304) * Only call `zero_range()` and `as.numeric()` in transformed space In case the `limits` in data space don't support conversion to numeric * Add comment with link to PR * NEWS bullet --------- Co-authored-by: Teun van den Brand <[email protected]>
* Update r4ds url - This pull request updates r4ds(<https://r4ds.had.co.nz/>) to r4ds 2e (https://r4ds.hadley.nz/). * run `devtools::build_readme()` It updates **README.md** by running `devtools::build_readme()`.
* fortify.default() accepts data-frame-like objects `fortify.default()` now accepts a data-frame-like object granted the object exhibits healthy `dim()`, `colnames()`, and `as.data.frame()` behaviors. Closes tidyverse#5390. * Update snapshot of ggplot(aes(x = x)) * Improve fortify.default() based on Teun's feedback * Follow style guide a little bit more closely in error messages (see https://style.tidyverse.org/error-messages.html)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.