Fix some errors be ignored

[drivebyer]

In Create() function, some errors not been check. It will cause cluster status to unexpected.

For example:

postgres-operator/pkg/cluster/cluster.go

Lines 271 to 273 in 0e7beb5

	if c.Endpoints[role] != nil {
	return fmt.Errorf("%s endpoint already exists in the cluster", role)
	}

[FxKu]

I don't get what this code change improves? Can you explain in a bit more detail? I've had a quick look at the Create() code and it looked fine to me.

[drivebyer]

I don't get what this code change improves? Can you explain in a bit more detail? I've had a quick look at the Create() code and it looked fine to me.

Such as following code in Create():

postgres-operator/pkg/cluster/cluster.go

Lines 286 to 288 in 0e7beb5

	if c.Services[role] != nil {
	return fmt.Errorf("service already exists in the cluster")
	}

If c.Services[role] != nil. There error will not be assigned to err variable. So it will go to first branch in following defer:

postgres-operator/pkg/cluster/cluster.go

Lines 255 to 261 in 0e7beb5

	defer func() {
	if err == nil {
	c.KubeClient.SetPostgresCRDStatus(c.clusterName(), acidv1.ClusterStatusRunning) //TODO: are you sure it's running?
	} else {
	c.KubeClient.SetPostgresCRDStatus(c.clusterName(), acidv1.ClusterStatusAddFailed)
	}
	}()

Actually, we should go to second branch.

Here is example code:
https://go.dev/play/p/BEi5R6GATfG

[FxKu]

Ah, there's a defer block. Now I got it. Thanks!

[FxKu]

👍

[jopadi]

👍