fix(chart): Add patroni configuration in operatorconfiguration #2297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thcdrt
requested review from
sdudoladov,
Jan-M,
FxKu,
jopadi,
idanovinda and
hughcapet
as code owners
FxKu
reviewed
Apr 20, 2023
|
can you also uncomment the config in the sample manifest. So that it's not overlooked too easily. |
thcdrt
force-pushed
the
dev/tacouder/fix-helm-chart-failsafe-mode
branch
from
65daace to
5c6157d
Compare
thcdrt
force-pushed
the
dev/tacouder/fix-helm-chart-failsafe-mode
branch
from
5c6157d to
979ceeb
Compare
FxKu
reviewed
Apr 20, 2023
|
👍 |
|
Thanks @thcdrt for the quick update. I've noticed a few more issues around the config option and will follow up in another PR. |
|
Thanks to you @FxKu for your reactivity ! |
|
I will close this PR since we went forward with #2298 where it is included. Thanks again for raising it so it will be included in the release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
When trying to enable patroni DCS failsafe mode, I found out that in PR 2076 the parameter
failsafe_modewas added to Helm chart values file, but this configuration was never applied inside the templates.I tested this fix and it's working as expected.
Thomas