update K8s version and reflect necessary changes #2740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FxKu
requested review from
sdudoladov,
Jan-M,
jopadi,
idanovinda,
hughcapet and
macedigital
as code owners
macedigital
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Looks good to me. I wouldn't expect the changes to be backward necessarily incompatible with 1.28.x, but highly recommend to mention this as potentially breaking change.
Wouldn't it also be possible to spin up a 1.28.x minikube cluster to check for compatibility ?
|
👍 |
|
I tested with minikube 1.28 and I could spin up clusters. Therefore, we can merge it. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I intentionally did not change it for v1.13.0 because I'm not sure if the operator would then stop working for K8s 1.28- any longer.