Skip to content

chore(deps): bump swagger-parser from 2.1.12 to 2.1.26 #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brennoo
Copy link

@brennoo brennoo commented May 7, 2025

This PR is bumping io.swagger.parser.v3:swagger-parser from 2.1.12 (Feb 15, 2023) to 2.1.26 (Mar 25, 2025)

After the update some tests started failing, example:

ReverseAstTest > OpenAPI extension JsonPointers are parsed correctly() FAILED
    org.opentest4j.AssertionFailedError:
    expected: /info/x-test-extension
     but was: /info//x-test-extension
        at [email protected]/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
        at [email protected]/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
        at [email protected]/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
        at [email protected]/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
        at app//org.zalando.zally.core.ast.ReverseAstTest.OpenAPI extension JsonPointers are parsed correctly(ReverseAstTest.kt:240) 

so I had to make an adjust in handleObject to ensure that the extension map itself wont add an empty path.

after that, there were some issues with java-mail, example:

JsonSchemaValidatorTest > invalid schemas result in empty violation pointers() FAILED
    java.lang.NoClassDefFoundError: javax/mail/internet/AddressException
        at com.github.fge.jsonschema.library.format.CommonFormatAttributesDictionary.<clinit>(CommonFormatAttributesDictionary.java:56)
        at com.github.fge.jsonschema.library.format.DraftV3FormatAttributesDictionary.<clinit>(DraftV3FormatAttributesDictionary.java:47)
        at com.github.fge.jsonschema.library.DraftV3Library.<clinit>(DraftV3Library.java:36)
        at com.github.fge.jsonschema.cfg.ValidationConfigurationBuilder.<clinit>(ValidationConfigurationBuilder.java:63)
        at com.github.fge.jsonschema.cfg.ValidationConfiguration.newBuilder(ValidationConfiguration.java:97)
        at org.zalando.zally.core.JsonSchemaValidator.createValidatorFactory(JsonSchemaValidator.kt:83)
        at org.zalando.zally.core.JsonSchemaValidator.<init>(JsonSchemaValidator.kt:29)
        at org.zalando.zally.core.JsonSchemaValidator.<init>(JsonSchemaValidator.kt:18)
        at org.zalando.zally.core.JsonSchemaValidatorTest.invalid schemas result in empty violation pointers(JsonSchemaValidatorTest.kt:64)

        Caused by:
        java.lang.ClassNotFoundException: javax.mail.internet.AddressException
            at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
            at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
            at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:525)
            ... 9 more 

making the dependency explicit fixed those, build s green ✅

@brennoo brennoo requested a review from tkrop as a code owner May 7, 2025 06:51
@zalando-robot
Copy link

Cannot start a pipeline due to:

No accountable user for this pipeline: no Zalando employee associated to this GitHub username

Click on pipeline status check Details link below for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants