5x

.github/workflows/build-and-test.yml

@@ -99,7 +99,7 @@ jobs:
       - name: Restore
         run: dotnet restore "${{ env.PROJECT_PATH }}"
 
-      - name: Build
+      - name: 🔨 Build
         run: >-
           dotnet build "${{ env.PROJECT_PATH }}"  
           --configuration "${{ env.CONFIGURATION }}" 

.github/workflows/publish.yml

@@ -128,7 +128,7 @@ jobs:
       - name: Install dependencies
         run: dotnet restore "${{ env.PROJECT_PATH }}"
 
-      - name: Create the package
+      - name: 📦 Create the package
         run: >-
           dotnet pack "${{ env.PROJECT_PATH }}"
           --output ./artifacts
@@ -140,7 +140,7 @@ jobs:
           -p:IncludeSymbols=true
           -p:SymbolPackageFormat=snupkg
 
-      - name: Create the package - Signed
+      - name: 📦 Create the package - Signed 
         run: >-
           dotnet pack "${{ env.PROJECT_PATH }}"
           --output ./artifacts

Directory.Build.props

@@ -5,5 +5,17 @@
         <Features>strict</Features>
         <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
     </PropertyGroup>
+
+    <PropertyGroup Condition="'$(Configuration)' == 'Release'">
+        <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
+        <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
+        <Deterministic>true</Deterministic>
+        <EmbedUntrackedSources>true</EmbedUntrackedSources>
+    </PropertyGroup>
+
+<!--    <ItemGroup>-->
+<!--        <PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" PrivateAssets="all" />-->
+<!--        &lt;!&ndash;        <PackageReference Include="StyleCop.Analyzers" PrivateAssets="All" />&ndash;&gt;-->
+<!--    </ItemGroup>-->
 
 </Project>

Directory.Packages.props

@@ -0,0 +1,29 @@
+<Project>
+    <PropertyGroup>
+        <Net20_Net46>|net20|net40|net45|net451|net452|net46|</Net20_Net46>
+        <Net20_Net461>|net20|net40|net45|net451|net452|net46|net461|</Net20_Net461>
+        <Net45_Net46>|net45|net451|net452|net46|</Net45_Net46>
+        <Net45_Net461>|net45|net451|net452|net46|net461|</Net45_Net461>
+    </PropertyGroup>
+    <ItemGroup Label="Build">
+        <PackageVersion Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.3" PrivateAssets="all" IncludeAssets="runtime; build; native; contentfiles; analyzers; buildtransitive" />
+        <PackageVersion Include="Newtonsoft.Json" Version="13.0.3" />
+    </ItemGroup>    
+    <ItemGroup Condition=" '$(TargetFramework)' == 'net40' " Label=".NET 4.0 Package References">
+        <PackageVersion Include="System.ValueTuple" Version="4.5.0"  />
+        <PackageVersion Include="Microsoft.Bcl.Async" Version="1.0.168" />
+        <PackageVersion Include="Microsoft.Net.Http" Version="2.2.29" />
+    </ItemGroup>
+    <ItemGroup Condition=" $(Net45_Net461.Contains('|$(TargetFramework)|'))" >
+        <PackageVersion Include="System.Net.Http" Version="4.3.4" />
+        <PackageVersion Include="System.Buffers" Version="4.5.1" />
+        <PackageVersion Include="System.Memory" Version="4.5.5" />
+    </ItemGroup>
+    <ItemGroup Condition=" $(Net20_Net461.Contains('|$(TargetFramework)|')) == FALSE "  >
+        <PackageVersion Include="System.ValueTuple" Version="4.6.1"  />
+        <PackageVersion Include="System.Buffers" Version="4.6.1" />
+        <PackageVersion Include="System.Memory" Version="4.6.3" />
+        <PackageVersion Include="Microsoft.Extensions.Http" Version="9.0.5" />
+        <PackageVersion Include="Microsoft.Extensions.Logging" Version="9.0.5" />
+    </ItemGroup>
+</Project>

docker-compose.yml

@@ -4,8 +4,8 @@ services:
   redmine:
     ports:
       - '8089:3000'
-    image: 'redmine:5.1.1-alpine'
-    container_name: 'redmine-web'
+    image: 'redmine:6.0.5-alpine'
+    container_name: 'redmine-web605'
     depends_on:
       - db-postgres
     # healthcheck:
@@ -32,8 +32,8 @@ services:
       POSTGRES_DB: redmine
       POSTGRES_USER: redmine-usr
       POSTGRES_PASSWORD: redmine-pswd
-    container_name: 'redmine-db'
-    image: 'postgres:16-alpine'
+    container_name: 'redmine-db175'
+    image: 'postgres:17.5-alpine'
     healthcheck:
       test: ["CMD-SHELL", "pg_isready -U postgres"]
       interval: 20s

global.json

@@ -1,6 +1,6 @@
 {
   "sdk": {
-    "version": "9.0.101",
+    "version": "9.0.203",
     "allowPrerelease": false,
     "rollForward": "latestMajor"
   }

redmine-net-api.sln

@@ -38,6 +38,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Props", "Props", "{707B6A3F
 		releasenotes.props = releasenotes.props
 		signing.props = signing.props
 		version.props = version.props
+		Directory.Packages.props = Directory.Packages.props
 	EndProjectSection
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Docker", "Docker", "{1D340EEB-C535-45D4-80D7-ADD4434D7B77}"

src/redmine-net-api/Authentication/RedmineApiKeyAuthentication.cs

@@ -15,6 +15,7 @@ limitations under the License.
 */
 
 using System.Net;
+using Redmine.Net.Api.Extensions;
 
 namespace Redmine.Net.Api.Authentication;
 
@@ -24,7 +25,7 @@ namespace Redmine.Net.Api.Authentication;
 public sealed class RedmineApiKeyAuthentication: IRedmineAuthentication
 {
     /// <inheritdoc />
-    public string AuthenticationType => "X-Redmine-API-Key";
+    public string AuthenticationType { get; } = RedmineAuthenticationType.ApiKey.ToText();
 
     /// <inheritdoc />
     public string Token { get; init; }

src/redmine-net-api/Authentication/RedmineAuthenticationType.cs

@@ -0,0 +1,8 @@
+namespace Redmine.Net.Api.Authentication;
+
+internal enum RedmineAuthenticationType
+{
+    NoAuthentication,
+    Basic,
+    ApiKey
+}

src/redmine-net-api/Authentication/RedmineBasicAuthentication.cs

@@ -18,6 +18,7 @@ limitations under the License.
 using System.Net;
 using System.Text;
 using Redmine.Net.Api.Exceptions;
+using Redmine.Net.Api.Extensions;
 
 namespace Redmine.Net.Api.Authentication
 {
@@ -27,7 +28,7 @@ namespace Redmine.Net.Api.Authentication
     public sealed class RedmineBasicAuthentication: IRedmineAuthentication
     {
         /// <inheritdoc />
-        public string AuthenticationType => "Basic";
+        public string AuthenticationType { get; } = RedmineAuthenticationType.Basic.ToText();
 
         /// <inheritdoc />
         public string Token { get; init; }
@@ -45,7 +46,7 @@ public RedmineBasicAuthentication(string username, string password)
             if (username == null) throw new RedmineException(nameof(username));
             if (password == null) throw new RedmineException(nameof(password));
 
-            Token = Convert.ToBase64String(Encoding.UTF8.GetBytes($"{username}:{password}"));
+            Token = $"Basic {Convert.ToBase64String(Encoding.UTF8.GetBytes($"{username}:{password}"))}";
         }
     }
 }

src/redmine-net-api/Authentication/RedmineNoAuthentication.cs

@@ -15,6 +15,7 @@ limitations under the License.
 */
 
 using System.Net;
+using Redmine.Net.Api.Extensions;
 
 namespace Redmine.Net.Api.Authentication;
 
@@ -24,7 +25,7 @@ namespace Redmine.Net.Api.Authentication;
 public sealed class RedmineNoAuthentication: IRedmineAuthentication
 {
     /// <inheritdoc />
-    public string AuthenticationType => "NoAuth";
+    public string AuthenticationType { get; } = RedmineAuthenticationType.NoAuthentication.ToText();
 
     /// <inheritdoc />
     public string Token { get; init; }

src/redmine-net-api/Common/AType.cs

@@ -0,0 +1,12 @@
+using System;
+
+namespace Redmine.Net.Api.Common;
+
+internal readonly struct A<T>{
+    public static A<T> Is => default;
+#pragma warning disable CS0184 // 'is' expression's given expression is never of the provided type
+    public static bool IsEqual<U>() => Is is A<U>;
+#pragma warning restore CS0184 // 'is' expression's given expression is never of the provided type
+    public static Type Value => typeof(T);                         
+
+}

src/redmine-net-api/Common/ArgumentVerifier.cs

@@ -0,0 +1,43 @@
+using System;
+using System.Diagnostics.CodeAnalysis;
+
+namespace Redmine.Net.Api.Common;
+
+/// <summary>
+/// A utility class to perform argument validations. 
+/// </summary>
+internal static class ArgumentVerifier
+{
+    /// <summary>
+    /// Throws ArgumentNullException if the argument is null.
+    /// </summary>
+    /// <param name="value">Argument value to check.</param>
+    /// <param name="name">Name of Argument.</param>
+    public static void ThrowIfNull([NotNull] object value, string name)
+    {
+        if (value == null)
+        {
+            throw new ArgumentNullException(name);
+        }
+    }
+
+    /// <summary>
+    /// Validates string and throws:
+    /// ArgumentNullException if the argument is null.
+    /// ArgumentException if the argument is empty.
+    /// </summary>
+    /// <param name="value">Argument value to check.</param>
+    /// <param name="name">Name of Argument.</param>
+    public static void ThrowIfNullOrEmpty([NotNull] string value, string name)
+    {
+        if (value == null)
+        {
+            throw new ArgumentNullException(name);
+        }
+
+        if (string.IsNullOrEmpty(value))
+        {
+            throw new ArgumentException("The value cannot be null or empty", name);
+        }
+    }
+}

src/redmine-net-api/Types/IValue.cs → src/redmine-net-api/Common/IValue.cs

@@ -14,7 +14,7 @@ You may obtain a copy of the License at
    limitations under the License.
 */
 
-namespace Redmine.Net.Api.Types
+namespace Redmine.Net.Api.Common
 {
     /// <summary>
     /// 

src/redmine-net-api/Types/PagedResults.cs → src/redmine-net-api/Common/PagedResults.cs

@@ -16,7 +16,7 @@ limitations under the License.
 
 using System.Collections.Generic;
 
-namespace Redmine.Net.Api.Serialization
+namespace Redmine.Net.Api.Common
 {
     /// <summary>
     /// 
@@ -30,7 +30,7 @@ public sealed class PagedResults<TOut> where TOut: class
         /// <param name="total"></param>
         /// <param name="offset"></param>
         /// <param name="pageSize"></param>
-        public PagedResults(IEnumerable<TOut> items, int total, int offset, int pageSize)
+        public PagedResults(List<TOut> items, int total, int offset, int pageSize)
         {
             Items = items;
             TotalItems = total;
@@ -75,6 +75,6 @@ public PagedResults(IEnumerable<TOut> items, int total, int offset, int pageSize
         /// <summary>
         /// 
         /// </summary>
-        public IEnumerable<TOut> Items { get; }
+        public List<TOut> Items { get; }
     }
 }

src/redmine-net-api/Exceptions/RedmineException.cs

@@ -15,6 +15,7 @@ limitations under the License.
 */
 
 using System;
+using System.Diagnostics;
 using System.Globalization;
 using System.Runtime.Serialization;
 
@@ -24,6 +25,7 @@ namespace Redmine.Net.Api.Exceptions
     /// Thrown in case something went wrong in Redmine
     /// </summary>
     /// <seealso cref="System.Exception" />
+    [DebuggerDisplay($"{{{nameof(DebuggerDisplay)},nq}}")]
     [Serializable]
     public class RedmineException : Exception
     {
@@ -85,5 +87,7 @@ protected RedmineException(SerializationInfo serializationInfo, StreamingContext
 
         }
         #endif
+
+        private string DebuggerDisplay => $"[{Message}]";
     }
 }

src/redmine-net-api/Exceptions/RedmineSerializationException.cs

@@ -0,0 +1,48 @@
+using System;
+
+namespace Redmine.Net.Api.Exceptions;
+
+/// <summary>
+/// Represents an error that occurs during JSON serialization or deserialization.
+/// </summary>
+public class RedmineSerializationException : RedmineException
+{
+    /// <summary>
+    /// Initializes a new instance of the <see cref="RedmineSerializationException"/> class.
+    /// </summary>
+    public RedmineSerializationException()
+    {
+    }
+
+    /// <summary>
+    /// Initializes a new instance of the <see cref="RedmineSerializationException"/> class with a specified error message.
+    /// </summary>
+    /// <param name="message">The error message that explains the reason for the exception.</param>
+    public RedmineSerializationException(string message) : base(message)
+    {
+    }
+
+    /// <summary>
+    /// Initializes a new instance of the <see cref="RedmineSerializationException"/> class with a specified error message.
+    /// </summary>
+    /// <param name="message">The error message that explains the reason for the exception.</param>
+    ///  /// <param name="paramName">The name of the parameter that caused the exception.</param>
+    public RedmineSerializationException(string message, string paramName) : base(message)
+    {
+        ParamName = paramName;
+    }
+
+    /// <summary>
+    /// Initializes a new instance of the <see cref="RedmineSerializationException"/> class with a specified error message and a reference to the inner exception that is the cause of this exception.
+    /// </summary>
+    /// <param name="message">The error message that explains the reason for the exception.</param>
+    /// <param name="innerException">The exception that is the cause of the current exception, or a null reference if no inner exception is specified.</param>
+    public RedmineSerializationException(string message, Exception innerException) : base(message, innerException)
+    {
+    }
+
+    /// <summary>
+    /// Gets the name of the parameter that caused the current exception.
+    /// </summary>
+    public string ParamName { get; }
+}