-
Notifications
You must be signed in to change notification settings - Fork 3
Improve readability and test coverage of cli #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #42 +/- ##
===========================================
+ Coverage 94.87% 100.00% +5.12%
===========================================
Files 23 22 -1
Lines 898 905 +7
===========================================
+ Hits 852 905 +53
+ Misses 46 0 -46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Further changes:
|
Lakshmi-bashyam
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue: #40
Background info:
# any relevant background info for additional context, references to documentations etc.
codecov
plugin is highlighting that the most amount of lines missed by our unit tests reside in thequalle/interface/cli.py
script. We can improve our code coverage by adding more unit tests for the cli interface.cli_entrypoint()
method is too long. It should be split into smaller chunks in order to make it easier to test and to improve readability.Changes introduced:
# list changes to the code repo made in this pull request
tests/interface/test_cli.py
. These tests check the behavior of the methodcli_entrypoint()
and other methods inqualle/interface/cli.py
which were previously missed in our coverage.cli_entrypoint()
has been refactored to make it easier to read. Four different methods have been added to create subparsers which are being utilized by our cli.main.py
has been refactored slightly in order to write appropriate unit tests. The coverage is skipped for the line under theif
block. Some new unit tests have been under the scripttest_main.py