MVC InputFilterPluginManager missing InputFilterAbstractFactory config

[vaclavvanik]

InputFilterPluginManager in MVC environment does not create input filter defined in config.

Code to reproduce the issue

$config = [
    'input_filter_specs' => [
        MyInput::class => [
            //...
        ],
    ],
];

$inputFilter = $container->get(InputFilter\InputFilterPluginManager::class)->get(MyInput::class);

Expected results

InputFilterPluginManager creates defined InputFilter

Actual results

Exception thrown

Plugin of type MyInput is invalid; must implement Zend\InputFilter\InputFilterInterface or Zend\InputFilter\InputInterface

Imho this happens because Module.php provide incomplete config.

    public function getConfig()
    {
        $provider = new ConfigProvider();

        return [
            'service_manager' => $provider->getDependencyConfig(),
            'input_filters' => $provider->getInputFilterConfig(), // this line is missing
        ];
    }

[vaclavvanik]

@weierophinney do you think it is a bug? Should I create PR?

[froschdesign]

@vaclavvanik
Please look at:

zend-inputfilter/src/Module.php

Lines 30 to 42 in a23e67d

	public function init($moduleManager)
	{
	$event = $moduleManager->getEvent();
	$container = $event->getParam('ServiceManager');
	$serviceListener = $container->get('ServiceListener');
	$serviceListener->addServiceManager(
	'InputFilterManager',
	'input_filters',
	'Zend\ModuleManager\Feature\InputFilterProviderInterface',
	'getInputFilterConfig'
	);
	}

...and you will find input_filters.

[froschdesign]

Or do you try to add the entire specification as array in the configuration and not the factories?

[Xerkus]

Doesn't it say the problem right here:

Plugin of type MyInput is invalid; must implement Zend\InputFilter\InputFilterInterface or Zend\InputFilter\InputInterface

zend-inputfilter/src/InputFilterPluginManager.php

Lines 125 to 143 in a23e67d

	public function validate($plugin)
	{
	if ($plugin instanceof InputFilterInterface || $plugin instanceof InputInterface) {
	// Hook to perform various initialization, when the inputFilter is not created through the factory
	if ($plugin instanceof InitializableInterface) {
	$plugin->init();
	}
	// we're okay
	return;
	}
	throw new InvalidServiceException(sprintf(
	'Plugin of type %s is invalid; must implement %s or %s',
	(is_object($plugin) ? get_class($plugin) : gettype($plugin)),
	InputFilterInterface::class,
	InputInterface::class
	));
	}

your MyInput class does not implement those interfaces or extend other class that does

[froschdesign]

@Xerkus
I think @vaclavvanik wants to insert the input-filter specification as an array into the configuration and for this the InputFilterAbstractFactory must be added manually as described in the documentation:

Setup

When using zend-mvc version 2 releases, this functionality is disabled by default. To enable it, you must add the Zend\InputFilter\InputFilterAbstractServiceFactory abstract factory to the Zend\InputFilter\InputFilterPluginManager configuration, which is under the input_filters configuration key.

https://docs.zendframework.com/zend-inputfilter/specs/#setup

[Xerkus]

@froschdesign I see, $autoAddInvokableClass = true masked the problem.

[vaclavvanik]

@froschdesign as I wrote above I think, that it is a bug, that in Module.php is missing config line with input_filters. Which causes that InputFilterAbstractFactory is not registered in InputFilterPluginManager.

In ConfigProvider is InputFilterAbstractFactory registered.

[froschdesign]

@vaclavvanik
Did you see the hint in the documentation?

[vaclavvanik]

In the docs is:

For Expressive when using the configuration manager, and for zend-mvc v3 releases, the functionality is enabled by default, assuming you are using the component installer.

I am using mvc v3 and InputFilterAbstractFactory is not registered... :-/

[Xerkus]

Just checked, docs are indeed wrong. It is not registered for any mvc version by default.
Are there any reasons why we wouldn't want to enable it by default for mvc as well?

[froschdesign]

@vaclavvanik
I'm confused, unfortunately. If you use version v3 then you should have also the last version of zend-inputfilter! And the latest of version of zend-inputfilter contains the InputFilterAbstractFactory!

Or I'm wrong?

[froschdesign]

See:

• https://github.com/zendframework/zend-inputfilter/releases/tag/release-2.8.2
• Fix invalid abstract service factory configuration #162

[froschdesign]

@vaclavvanik
I will create a pull request when I'm back on my computer and will ping you for testing.

[vaclavvanik]

@froschdesign #162 fixed InputFilterAbstractFactory registration in ConfigProvider (Expressive). MVC v3 uses Module and in this class has not 'input_filters' config key in getConfig() which causes that InputFilterAbstractFactory is not registered... (really confusing)

[froschdesign]

@vaclavvanik

really confusing

Right, because in zend-form is the behaviour different. 😕