Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

[ZF3] Forward plugin doesn't detach problem listeners anymore. #246

Closed
nathanjosiah opened this issue Jun 14, 2017 · 1 comment
Closed
Labels
Milestone

Comments

@nathanjosiah
Copy link

Looks like there was a regressions as part of a v2 compatibility removable commit. The detachProblemListeners code builds the list of listeners to remove but doesn't actually remove them. For me, this manifests as my resulting ViewModel being double-rendered due to the InjectViewModelListener not actually being detached.

I will submit a PR to restore the block of code that actually detaches the listener.

nathanjosiah pushed a commit to nathanjosiah/zend-mvc that referenced this issue Jun 14, 2017
nathanjosiah pushed a commit to nathanjosiah/zend-mvc that referenced this issue Jun 14, 2017
@nathanjosiah nathanjosiah changed the title Forward plugin doesn't detach problem listeners anymore. [ZF3] Forward plugin doesn't detach problem listeners anymore. Jun 27, 2017
@nathanjosiah
Copy link
Author

@froschdesign What do I need to do to get this moving forward? I think this is the last issue preventing my team from upgrading to ZF3. My PR includes tests for both the attachment and detachment of the listeners.

@froschdesign froschdesign added this to the 3.1.1 milestone Jul 20, 2017
Xerkus added a commit that referenced this issue Nov 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants