This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Expose component as a config-provider / ZF component #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds: - `ConfigProvider`, which maps the default navigation factory and the navigation abstract factory, as well as the navigation view helper. - `Module`, which does the same as the above, but for zend-mvc applications. Deprecates: - `View\HelperConfig`, as the functionality is now wrapped in the above.
`HelperConfig` contains a lot of logic for ensuring that the navigation helpers are injected with the view helper plugin manager as well as the application container, and cannot be deprecated safely. As a result, this patch uses a new approach: a delegator factory, which uses `HelperConfig` to configure the helper manager before returning it. This approach should still be safe, as the various other approaches that configure it operate on the already retrieved helper manager instance.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds:
ConfigProvider, which maps the default navigation factory and the navigation abstract factory, as well as the navigation view helper.Module, which does the same as the above, but for zend-mvc applications.Deprecates:
View\HelperConfig, as the functionality is now wrapped in the above.