This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Update to allow usage with zend-mvc v3 #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-with-mvc-3 Feature/compatible with mvc 3
- Updated `Mvc` page type to inline the constants from zend-mvc's `ModuleRouteListener`; this means the code itself no longer depends on that functionality. - Added zend-router to the require-dev section so that we can test properly against it for all supported versions. - Kept the zend-mvc dev requirement, as we actually test against `ModuleRouteListener` (integration tests). - Updated the suggestions to be more descriptive of why they are needed, and which versions can be used.
Updated class to use the forwards-compatible `FactoryInterface`, and updated its `createService()` method to be compatible with v2.
…icemanager v2 Implement the v2 `DelegatorFactoryInterface`, which is forwards compatible.
Added setup methods for selecting the correct router artifacts based on the zend-mvc version (v2 will use the `Zend\Mvc\Router` variants, while v3 will use the `Zend\Router` classes). Tests that depend on any of concrete routes, routers, or route matches were updated to use these new setup methods to derive the class(es) to use.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch builds on #33, and makes the following changes:
composer.jsonto add zend-router as both a development and suggested dependency.composer.jsonto remove zend-mvc from the suggestions list.Mvcpage type to inline the zend-mvcModuleRouteListenerconstants, and thus remove the explicit dependency on it.Mvcpage type tests to vary test setup based on whether zend-mvc v2 or v3 is in use when testing.