Do not tag model via Model class on creation

docs/book/how-to/handle-data-artifacts/tagging.md

@@ -54,15 +54,19 @@ Note that [ZenML Pro](https://zenml.io/pro) users can tag artifacts directly in
 
 Just like artifacts, you can also tag your models to organize them semantically. Here's how to use tags with models in the ZenML Python SDK and CLI (or in the [ZenML Pro Dashboard directly](https://zenml.io/pro)).
 
-When creating a model using the `Model` object, you can specify tags as key-value pairs that will be attached to the model upon creation:
+When creating a model version using the `Model` object, you can specify tags as key-value pairs that will be attached to the model version upon creation.
+{% hint style="warning" %}
+During pipeline run a model can be also implicitly created (if not exists), in such cases it will not get the `tags` from the `Model` class.
+You can manipulate the model tags using SDK (see below) or the ZenML Pro UI.
+{% endhint %}
 
 ```python
 from zenml.models import Model
 
-# Define tags to be added to the model
+# Define tags to be added to the model version
 tags = ["experiment", "v1", "classification-task"]
 
-# Create a model with tags
+# Create a model version with tags
 model = Model(
     name="iris_classifier",
     version="1.0.0",

src/zenml/model/model.py

@@ -569,7 +569,6 @@ def _get_or_create_model(self) -> "ModelResponse":
                     limitations=self.limitations,
                     trade_offs=self.trade_offs,
                     ethics=self.ethics,
-                    tags=self.tags,
                     user=zenml_client.active_user.id,
                     workspace=zenml_client.active_workspace.id,
                     save_models_to_registry=self.save_models_to_registry,

src/zenml/models/v2/core/model.py

@@ -82,6 +82,7 @@ class ModelRequest(WorkspaceScopedRequest):
     )
     tags: Optional[List[str]] = Field(
         title="Tags associated with the model",
+        default=None,
     )
     save_models_to_registry: bool = Field(
         title="Whether to save all ModelArtifacts to Model Registry",

tests/integration/functional/model/test_model_version.py

@@ -198,7 +198,7 @@ def test_model_create_model_and_version(self):
             assert mv.name == str(mv.number)
             assert mv.model.name == mdl_name
             assert {t.name for t in mv.tags} == {"tag1", "tag2"}
-            assert {t.name for t in mv.model.tags} == {"tag1", "tag2"}
+            assert len(mv.model.tags) == 0
 
     def test_create_model_version_makes_proper_tagging(self):
         """Test if model versions get unique tags."""
@@ -208,14 +208,14 @@ def test_create_model_version_makes_proper_tagging(self):
             assert mv.name == str(mv.number)
             assert mv.model.name == mdl_name
             assert {t.name for t in mv.tags} == {"tag1", "tag2"}
-            assert {t.name for t in mv.model.tags} == {"tag1", "tag2"}
+            assert len(mv.model.tags) == 0
 
             mv = Model(name=mdl_name, tags=["tag3", "tag4"])
             mv = mv._get_or_create_model_version()
             assert mv.name == str(mv.number)
             assert mv.model.name == mdl_name
             assert {t.name for t in mv.tags} == {"tag3", "tag4"}
-            assert {t.name for t in mv.model.tags} == {"tag1", "tag2"}
+            assert len(mv.model.tags) == 0
 
     def test_model_fetch_model_and_version_by_number(self):
         """Test model and model version retrieval by exact version number."""
@@ -301,15 +301,17 @@ def test_tags_properly_created(self):
 
                     # run 2 times to first create, next get
                     for _ in range(2):
-                        model = mv._get_or_create_model()
+                        model_version = mv._get_or_create_model_version()
 
-                        assert len(model.tags) == 2
-                        assert {t.name for t in model.tags} == {
+                        assert len(model_version.tags) == 2
+                        assert {t.name for t in model_version.tags} == {
                             green_tag,
                             new_tag,
                         }
                         assert {
-                            t.color for t in model.tags if t.name == green_tag
+                            t.color
+                            for t in model_version.tags
+                            if t.name == green_tag
                         } == {"green"}
 
     def test_tags_properly_updated(self):
@@ -324,10 +326,8 @@ def test_tags_properly_updated(self):
 
             client.update_model(model_id, add_tags=["tag1", "tag2"])
             model = mv._get_or_create_model()
-            assert len(model.tags) == 4
+            assert len(model.tags) == 2
             assert {t.name for t in model.tags} == {
-                "foo",
-                "bar",
                 "tag1",
                 "tag2",
             }
@@ -346,8 +346,7 @@ def test_tags_properly_updated(self):
 
             client.update_model(model_id, remove_tags=["tag1", "tag2"])
             model = mv._get_or_create_model()
-            assert len(model.tags) == 2
-            assert {t.name for t in model.tags} == {"foo", "bar"}
+            assert len(model.tags) == 0
 
             client.update_model_version(
                 model_id, "1", remove_tags=["tag3", "tag4"]