-
Notifications
You must be signed in to change notification settings - Fork 516
Better input artifacts typing #3099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
avishniakov
merged 67 commits into
develop
from
feature/PRD-668-better-input-artifacts-typing
Nov 7, 2024
Merged
Changes from all commits
Commits
Show all changes
67 commits
Select commit
Hold shift + click to select a range
9bdb5f1
multi-versioned outputs
avishniakov 4dd7e90
more artifact save types
avishniakov eb7f691
fix for the llm template
avishniakov 49f0f24
Auto-update of LLM Finetuning template
actions-user 5d81b5d
Merge branch 'develop' into feature/PRD-663-multiple-output-versions-…
avishniakov ac9a7bd
Auto-update of Starter template
actions-user 9607df5
Auto-update of E2E template
actions-user fc19dc3
fix tests notation
avishniakov 9f04da1
Merge branch 'feature/PRD-663-multiple-output-versions-for-a-step' of…
avishniakov feb3f53
Refactor artifact saving logic to use save types
avishniakov 5557837
Refactor artifact saving logic to use save types
avishniakov eac4aea
Remove unneeded TODO
avishniakov e62d8eb
Refactor artifact saving logic to use list instead of set for output …
avishniakov f4bf134
Merge branch 'develop' into feature/PRD-663-multiple-output-versions-…
avishniakov 9a8cf20
Refactor artifact saving logic to use outputs instead of saved_artifa…
avishniakov ecb9ff0
Merge branch 'develop' into feature/PRD-663-multiple-output-versions-…
avishniakov 5683081
Auto-update of LLM Finetuning template
actions-user f02fee1
Refactor artifact saving logic to use 'external' as the default save …
avishniakov 0a2dfa1
Refactor artifact saving logic to use outputs instead of saved_artifa…
avishniakov 77b6a79
Merge branch 'develop' into feature/PRD-663-multiple-output-versions-…
avishniakov 27099b4
Refactor artifact saving logic to define input types. WIP
avishniakov a704f95
Refactor StepRunRequestFactory to correctly assign output artifacts
avishniakov e991fd5
Merge branch 'feature/PRD-663-multiple-output-versions-for-a-step' of…
avishniakov e7d7a62
Merge branch 'feature/PRD-663-multiple-output-versions-for-a-step' in…
avishniakov 9ce83ee
Refactor StepRunRequestFactory to correctly assign output artifacts
avishniakov 8930510
Refactor StepRunRequestFactory to correctly assign input artifact types
avishniakov fc81ecf
Refactor StepRunRequestFactory to correctly assign input artifact typ…
avishniakov dec188c
Add test case
avishniakov d036010
bugs, bugs
avishniakov a2d735c
mypy
avishniakov 980fac6
Merge branch 'feature/PRD-663-multiple-output-versions-for-a-step' in…
avishniakov 53f5657
mypy
avishniakov 56a37a8
Remove unused arg
schustmi b5c8ad0
Improve input resolution
schustmi 3d2443b
Rename save type
schustmi aef08fc
Only apply artifact config to step outputs
schustmi 239122e
Merge branch 'develop' into feature/PRD-663-multiple-output-versions-…
schustmi eaf2958
Fix alembic order
schustmi fc0c141
Fix DB migration
schustmi 54527dc
Merge branch 'feature/PRD-663-multiple-output-versions-for-a-step' in…
schustmi 1b246d2
Formatting
schustmi 65b1443
Migrate default input type
schustmi ce76a9c
Detect input type server side
schustmi 8b51d47
Fix input type detection
schustmi 5f1c7fc
Don't fail for cached step runs
schustmi 1ecefd8
Merge branch 'develop' into feature/PRD-663-multiple-output-versions-…
schustmi 9a39cd4
Fix alembic order
schustmi 48b28f2
Merge branch 'feature/PRD-663-multiple-output-versions-for-a-step' in…
schustmi 3193c20
Refactor artifact saving in cacheable_multiple_versioned_producer
avishniakov 3797a07
Merge branch 'develop' into feature/PRD-663-multiple-output-versions-…
avishniakov e49ff02
Merge branch 'feature/PRD-663-multiple-output-versions-for-a-step' in…
avishniakov 2986c7a
remove duplicated logic from `load_artifact`
avishniakov 5b6bf57
add `StepRunInputResponse`
avishniakov f9c4455
add `StepRunInputResponse`
avishniakov e3e9320
Merge branch 'develop' into feature/PRD-663-multiple-output-versions-…
avishniakov 5cf1089
Merge branch 'develop' into feature/PRD-663-multiple-output-versions-…
avishniakov ad7b3da
Merge branch 'feature/PRD-663-multiple-output-versions-for-a-step' in…
avishniakov 58e75f2
Merge branch 'develop' into feature/PRD-663-multiple-output-versions-…
schustmi d0e2633
Merge branch 'develop' into feature/PRD-663-multiple-output-versions-…
avishniakov aeafc20
Merge branch 'feature/PRD-663-multiple-output-versions-for-a-step' in…
avishniakov 3e3c32d
lint
avishniakov ca27fad
Merge branch 'develop' into feature/PRD-668-better-input-artifacts-ty…
avishniakov 4b44d39
fix typing issues
avishniakov 4b6c922
Refactor resolve_step_inputs function to use StepRunInputResponse for…
avishniakov e59793c
Merge branch 'develop' into feature/PRD-668-better-input-artifacts-ty…
avishniakov f23772c
fix issues caught in testing
avishniakov 612e281
fix migration for mysql
avishniakov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.