Skip to content

Updating the sagemaker dependency in the AWS integration #3132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

bcdurak
Copy link
Contributor

@bcdurak bcdurak commented Oct 23, 2024

Describe changes

Following the PR here, sagemaker changed how they handled tags in their pipeline interface. In order to be compatible with it, we have to update our sagemaker dependency to the version >=v2.203.0, released on 2023-12-28, where this change eventually got released.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
  • If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@bcdurak bcdurak requested review from htahir1 and schustmi October 23, 2024 14:51
@github-actions github-actions bot added internal To filter out internal PRs and issues bug Something isn't working labels Oct 23, 2024
Copy link
Contributor

@AlexejPenner AlexejPenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦭

@bcdurak
Copy link
Contributor Author

bcdurak commented Oct 24, 2024

The problem with the tags is solved with this PR. Until we can work on the dependency issues between the aws and huggingface, I am closing this PR.

@bcdurak bcdurak closed this Oct 24, 2024
@bcdurak bcdurak deleted the bugfix/sagemaker-tags branch October 24, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal To filter out internal PRs and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants