-
Notifications
You must be signed in to change notification settings - Fork 514
Allow artifact response as step input #3134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow artifact response as step input #3134
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the intention here. However, I am still a bit unsure about using the name external_artifact
for ArtifactVersionResponse
s, but I trust your judgement on this.
PS: A small example along with an explanation might fit nicely here.
@bcdurak Agreed on the docs, I'll do that in a follow up PR where I will have to refactor them quite a bit to explain the updated lazy loading behaviour |
Describe changes
This PR adds the ability to add
ArtifactVersionResponse
s as a step input. This enables users to pass artifacts that were produced by previous pipelines or registered manually to their steps as inputs.There will be a follow-up PR which updates the behaviour of the lazy-loading client methods, which will update the docs and also include docs for this feature once it can be explained more clearly what is happening when these client methods get called inside or outside of a pipeline context.
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes