Add unique instance label to helm chart #3639
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe changes
It is currently not possible to properly configure Kubernetes affinity rules for ZenML Helm deployments for the following reason: there is no way to uniquely label all the pods belonging to the same ZenML Helm deployment.
Currently, all pods belonging to the same deployment are labeled with:
where
.Release.Name
is the name used for the Helm release and is usually not unique across a Kubernetes cluster (e.g. usually just set tozenml
). When deploying multiple ZenML servers in the same cluster, this poses a problem, because multiple ZenML pods may have the same labels (albeit across different namespaces).This PR introduces a new option,
zenml.instanceLabel
that when set will be used as aapp.kubernetes.io/instance
label value instead of.Release.Name
.Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes