Skip to content

Fix typos, bugs, and improve test precision #3678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2025

Conversation

strickvl
Copy link
Contributor

@strickvl strickvl commented May 17, 2025

Changes

  • Fixed a minor spacing issue in the orphaned assets script warning message
  • Corrected a typo in the schedule.py warning message ('interval_seconds' → 'interval_second')
  • Fixed a string formatting error in LocalDaemonService logging
  • Enhanced test precision by checking for specific error message content

Why

These changes improve code quality and maintenance by fixing small but important issues:

  • Consistent spacing in warning messages
  • Accurate parameter names in logs
  • Proper string formatting in error logs
  • More precise test assertions to catch potential regressions

All changes are non-functional but improve code quality and developer experience.

Copy link
Contributor

coderabbitai bot commented May 17, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the internal To filter out internal PRs and issues label May 17, 2025
@strickvl strickvl requested a review from Copilot May 17, 2025 09:45
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes typos in log and warning messages, updates a test to assert on a specific error message, and corrects an option name mismatch.

  • Clean up duplicate wording in the local service log message
  • Correct option name in the schedule warning
  • Tighten the IO utils test to check for a specific exception message

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
tests/unit/utils/test_io_utils.py Added match="Content must be of type str" to the pytest.raises call
src/zenml/services/local/local_service.py Removed the duplicated "for" in the logger.error message
src/zenml/config/schedule.py Changed interval_seconds to interval_second in the warning
Comments suppressed due to low confidence (1)

src/zenml/config/schedule.py:111

  • The option name interval_second is incorrect and inconsistent with the actual interval_seconds parameter. It should be updated back to interval_seconds to match the real config and avoid confusion.
"values for `start_time` and `interval_second`. The resulting "

@strickvl strickvl changed the title Fix typos, docstring, and test Fix typos, bugs, and improve test precision May 17, 2025
@strickvl strickvl requested review from htahir1 and Copilot May 17, 2025 09:51
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes typos and minor bugs while enhancing test precision and error reporting.

  • Updates test assertions to check for a precise error message on invalid file content.
  • Removes a duplicate word in a log message in the local daemon service.
  • Corrects a parameter name typo in a schedule configuration warning.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
tests/unit/utils/test_io_utils.py Updated test to assert a specific error message for non-string file content
src/zenml/services/local/local_service.py Removed duplicate wording in a log message indicating a missing process
src/zenml/config/schedule.py Fixed a typo in a warning message by correcting the parameter name from plural to singular

@strickvl strickvl requested review from AlexejPenner and bcdurak and removed request for htahir1 and AlexejPenner May 17, 2025 09:51
@strickvl strickvl added the documentation Improvements or additions to documentation label May 17, 2025
@strickvl strickvl merged commit dba762e into develop May 20, 2025
69 of 73 checks passed
@strickvl strickvl deleted the codex/find-issues-and-propose-fix-tasks branch May 20, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codex documentation Improvements or additions to documentation internal To filter out internal PRs and issues run-slow-ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants