-
Notifications
You must be signed in to change notification settings - Fork 509
Fix typos, bugs, and improve test precision #3678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes typos in log and warning messages, updates a test to assert on a specific error message, and corrects an option name mismatch.
- Clean up duplicate wording in the local service log message
- Correct option name in the schedule warning
- Tighten the IO utils test to check for a specific exception message
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
tests/unit/utils/test_io_utils.py | Added match="Content must be of type str" to the pytest.raises call |
src/zenml/services/local/local_service.py | Removed the duplicated "for" in the logger.error message |
src/zenml/config/schedule.py | Changed interval_seconds to interval_second in the warning |
Comments suppressed due to low confidence (1)
src/zenml/config/schedule.py:111
- The option name
interval_second
is incorrect and inconsistent with the actualinterval_seconds
parameter. It should be updated back tointerval_seconds
to match the real config and avoid confusion.
"values for `start_time` and `interval_second`. The resulting "
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes typos and minor bugs while enhancing test precision and error reporting.
- Updates test assertions to check for a precise error message on invalid file content.
- Removes a duplicate word in a log message in the local daemon service.
- Corrects a parameter name typo in a schedule configuration warning.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
tests/unit/utils/test_io_utils.py | Updated test to assert a specific error message for non-string file content |
src/zenml/services/local/local_service.py | Removed duplicate wording in a log message indicating a missing process |
src/zenml/config/schedule.py | Fixed a typo in a warning message by correcting the parameter name from plural to singular |
Changes
Why
These changes improve code quality and maintenance by fixing small but important issues:
All changes are non-functional but improve code quality and developer experience.